From: "Bjørn Mork" <bjorn@mork.no>
To: YueHaibing <yuehaibing@huawei.com>
Cc: <davem@davemloft.net>, <kuba@kernel.org>, <masahiroy@kernel.org>,
<miguel@det.uvigo.gal>, <linux-usb@vger.kernel.org>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: cdc_ncm: Fix build error
Date: Wed, 26 Aug 2020 09:03:23 +0200 [thread overview]
Message-ID: <87k0xl7utg.fsf@miraculix.mork.no> (raw)
In-Reply-To: <20200826065231.14344-1-yuehaibing@huawei.com> (yuehaibing@huawei.com's message of "Wed, 26 Aug 2020 14:52:31 +0800")
YueHaibing <yuehaibing@huawei.com> writes:
> If USB_NET_CDC_NCM is y and USB_NET_CDCETHER is m, build fails:
>
> drivers/net/usb/cdc_ncm.o:(.rodata+0x1d8): undefined reference to `usbnet_cdc_update_filter'
>
> Select USB_NET_CDCETHER for USB_NET_CDC_NCM to fix this.
Ouch. For some reason I assumed that was always selected with usbnet.
Thanks for fixing.
Bjørn
next prev parent reply other threads:[~2020-08-26 7:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 6:52 YueHaibing
2020-08-26 7:03 ` Bjørn Mork [this message]
2020-08-26 14:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0xl7utg.fsf@miraculix.mork.no \
--to=bjorn@mork.no \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=miguel@det.uvigo.gal \
--cc=netdev@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®