From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751879AbdJBOXs (ORCPT ); Mon, 2 Oct 2017 10:23:48 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:50105 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751717AbdJBOXo (ORCPT ); Mon, 2 Oct 2017 10:23:44 -0400 From: Gregory CLEMENT To: wsa@the-dreams.de Cc: Kalyan Kinthada , jason@lakedaemon.net, andrew@lunn.ch, sebastian.hesselbarth@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, Chris Packham Subject: Re: [PATCH v2 2/2] dt-bindings: i2c: Update documentation for "mv78230-a0-i2c" References: <20170928213605.22874-1-kalyan.kinthada@alliedtelesis.co.nz> <20170928213605.22874-3-kalyan.kinthada@alliedtelesis.co.nz> Date: Mon, 02 Oct 2017 16:23:43 +0200 In-Reply-To: <20170928213605.22874-3-kalyan.kinthada@alliedtelesis.co.nz> (Kalyan Kinthada's message of "Fri, 29 Sep 2017 10:36:05 +1300") Message-ID: <87k20dmxw0.fsf@free-electrons.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Wolfram, On ven., sept. 29 2017, Kalyan Kinthada wrote: > This commit modifies the documentation for > "marvell,mv78230-a0-i2c" compatible string. > > The "marvell,mv78230-a0-i2c" compatible string enables the workaround > for an i2c repeated start timing violation, but unlike > "marvell,mv78230-i2c" it disables the i2c offload support. This is > applicable to a number of SoCs such as early revisions of the Armada XP > and the Armada 38x. > > Signed-off-by: Kalyan Kinthada I applied the dt fix on my mvebu/fixes branch. Do you want to apply this one on your branch, or do you prefer I take it. In this case an acked-by would be nice. Thanks, Gregory > --- > Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt b/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt > index 5c30026921ae..c6cbab17ed0a 100644 > --- a/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt > +++ b/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt > @@ -10,10 +10,12 @@ Required properties : > - "marvell,mv64xxx-i2c" > - "marvell,mv78230-i2c" > - "marvell,mv78230-a0-i2c" > - * Note: Only use "marvell,mv78230-a0-i2c" for a > - very rare, initial version of the SoC which > - had broken offload support. Linux > - auto-detects this and sets it appropriately. > + * Note: Use "marvell,mv78230-a0-i2c" for > + controller which do not support offload > + but still have the i2c repeated start > + timing violation issue, such as the > + ones found in the Armada XP A0 and the > + Armada 38x SoCs. > - interrupts : The interrupt number > > Optional properties : > -- > 2.14.1 > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com