From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755308AbdGKGbX (ORCPT ); Tue, 11 Jul 2017 02:31:23 -0400 Received: from ozlabs.org ([103.22.144.67]:39725 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755235AbdGKGbV (ORCPT ); Tue, 11 Jul 2017 02:31:21 -0400 From: Michael Ellerman To: Palmer Dabbelt , yamada.masahiro@socionext.com, mmarek@suse.com, will.deacon@arm.com, peterz@infradead.org, boqun.feng@gmail.com, mingo@redhat.com, daniel.lezcano@linaro.org, tglx@linutronix.de, jason@lakedaemon.net, marc.zyngier@arm.com, gregkh@linuxfoundation.org, jslaby@suse.com, davem@davemloft.net, mchehab@kernel.org, sfr@canb.auug.org.au, fweisbec@gmail.com, viro@zeniv.linux.org.uk, mcgrof@kernel.org, dledford@redhat.com, bart.vanassche@sandisk.com, sstabellini@kernel.org, daniel.vetter@ffwll.ch, msalter@redhat.com, nicolas.dichtel@6wind.com, james.hogan@imgtec.com, paul.gortmaker@windriver.com, linux@roeck-us.net, heiko.carstens@de.ibm.com, schwidefsky@de.ibm.com, linux-kernel@vger.kernel.org, patches@groups.riscv.org, akpm@linux-foundation.org Cc: albert@sifive.com, Palmer Dabbelt Subject: Re: [PATCH 17/17] RISC-V: Build Infastructure In-Reply-To: <20170711013924.22085-18-palmer@dabbelt.com> References: <20170711013924.22085-1-palmer@dabbelt.com> <20170711013924.22085-18-palmer@dabbelt.com> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Tue, 11 Jul 2017 16:31:18 +1000 Message-ID: <87k23f7adl.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Palmer Dabbelt writes: > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig > new file mode 100644 > index 000000000000..366f5f2cf106 > --- /dev/null > +++ b/arch/riscv/Kconfig > @@ -0,0 +1,294 @@ ... > + > +config EARLY_PRINTK > + bool "Early printk" > + default n > + help > + This option enables special console drivers which allow the kernel > + to print messages very early in the bootup process. > + > + This is useful for kernel debugging when your machine crashes very > + early before the console code is initialized. For normal operation > + it is not recommended because it looks ugly and doesn't cooperate > + with klogd/syslogd or the X server. You should normally N here, > + unless you want to debug such a crash. Looks like you copied this text from x86? I think the comment about it being ugly refers to the VGA early console which you don't have, so that's not really accurate. And the part about it not cooperating with klogs/syslogd is true, early printk output doesn't go to syslog. But if you turn EARLY_PRINTK off then early printk output goes nowhere at all: #ifdef CONFIG_EARLY_PRINTK extern asmlinkage __printf(1, 2) void early_printk(const char *fmt, ...); #else static inline __printf(1, 2) __cold void early_printk(const char *s, ...) { } #endif So if you have a functional early console (which I think you do) then you might be better off just making this def_bool y. cheers