From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S965203AbdEVWLu (ORCPT <rfc822;w@1wt.eu>);
        Mon, 22 May 2017 18:11:50 -0400
Received: from anholt.net ([50.246.234.109]:53304 "EHLO anholt.net"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S964830AbdEVWLo (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 22 May 2017 18:11:44 -0400
From: Eric Anholt <eric@anholt.net>
To: Wei Yongjun <weiyj.lk@gmail.com>, David Airlie <airlied@linux.ie>,
        Tom Cooksey <tom.cooksey@arm.com>
Cc: Wei Yongjun <weiyongjun1@huawei.com>, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] drm/pl111: Fix return value check in pl111_amba_probe()
In-Reply-To: <20170521010152.6186-1-weiyj.lk@gmail.com>
References: <20170521010152.6186-1-weiyj.lk@gmail.com>
User-Agent: Notmuch/0.22.2+1~gb0bcfaa (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu)
Date: Mon, 22 May 2017 15:11:42 -0700
Message-ID: <87k2587d9d.fsf@eliezer.anholt.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha512; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

--=-=-=
Content-Type: text/plain

Wei Yongjun <weiyj.lk@gmail.com> writes:

> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> In case of error, the function devm_ioremap_resource() returns ERR_PTR()
> and never returns NULL. The NULL test in the return value check should
> be replaced with IS_ERR().
>
> Fixes: bed41005e617 ("drm/pl111: Initial drm/kms driver for pl111")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>

Reviewed and applied.  Thanks!

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlkjYh4ACgkQtdYpNtH8
nujylg/9EiJk90Ix+DG44gpLD0hW8j10BQ+LXwbCWtAUVFaPbcMkZyHHBoQBClh1
+ZrKKxSCmy9L3xCllTApfSVLxdwMJgwhBAgJ9Unp2PH/WmJGcngDmSTT+XwcedDl
+iTiAxW0/bI+URKmtgYXmMb8JiZejcP+002eeLfQgIVdQs0zPnGy7RMxzkN9KmIi
0n+e3YpbNVNzGBE/unEJ/mQDSrphS7riJ9y920xezgCPI19h0PivjkA9xfsezqY9
GtWrzPriiUh3WMVmfqmOsgYeNcjMjb2fS/XLXwyfXopbiQ91KM47oVbAu0dTZh4k
9LkELkENilbjZ9bsO6qzXKY4Jk5yYJPcO776DcC1e+s0try0nwhLLe+Kpx7qkpW2
qYlVDTsTH6zMHZC4gO9g95dgW6cL64qoGUGsZTnB+yuo2guUWdkI7uNxX//tfZd/
n/W4I6/tfKW2YhIA6hmUyHK14l6VeualDMydgv4kSXuMzubLnR7XIQ4Qhvep9xbr
+K7KmHsdJdE1oQ1gDMw7jsHvRa8OL/mhxCA/+WU6HMMieniuM8YyqDZ/NFzricgO
pWVwlggEyp3YgqW66CuxQpjjg4FD4jqOqJgWcKLG9nEzq7cTWEBH+/iBj7HgsVqU
Xfm/w+WigzNVrbET10GIbMnhQshVxqldilVJnsaqNiNewbYuZk8=
=5Yzw
-----END PGP SIGNATURE-----
--=-=-=--