From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933515AbdDEKdl (ORCPT ); Wed, 5 Apr 2017 06:33:41 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:56244 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933483AbdDEKd0 (ORCPT ); Wed, 5 Apr 2017 06:33:26 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org D797660A08 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: "Reshetova\, Elena" Cc: "netdev\@vger.kernel.org" , "linux-kernel\@vger.kernel.org" , "linux-arm-kernel\@lists.infradead.org" , "linux-rdma\@vger.kernel.org" , "linux-hams\@vger.kernel.org" , "linux-ppp\@vger.kernel.org" , "linux-wireless\@vger.kernel.org" , "ganeshgr\@chelsio.com" , "nbd\@openwrt.org" , "blogic\@openwrt.org" , "matthias.bgg\@gmail.com" , "yishaih\@mellanox.com" , "saeedm\@mellanox.com" , "matanb\@mellanox.com" , "leonro\@mellanox.com" , "ajk\@comnets.uni-bremen.de" , "paulus\@samba.org" , "j\@w1.fi" , "peterz\@infradead.org" , "keescook\@chromium.org" , "gregkh\@linuxfoundation.org" , Hans Liljestrand , David Windsor Subject: Re: [PATCH 16/16] drivers, net, intersil: convert request_context.refcount from atomic_t to refcount_t References: <1490691403-4016-1-git-send-email-elena.reshetova@intel.com> <1490691403-4016-17-git-send-email-elena.reshetova@intel.com> <87zifxn2gb.fsf@kamboji.qca.qualcomm.com> <2236FBA76BA1254E88B949DDB74E612B41C8741B@IRSMSX102.ger.corp.intel.com> Date: Wed, 05 Apr 2017 13:33:12 +0300 In-Reply-To: <2236FBA76BA1254E88B949DDB74E612B41C8741B@IRSMSX102.ger.corp.intel.com> (Elena Reshetova's message of "Tue, 4 Apr 2017 10:07:55 +0000") Message-ID: <87k26zi1p3.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "Reshetova, Elena" writes: >> Elena Reshetova writes: >> >> > refcount_t type and corresponding API should be >> > used instead of atomic_t when the variable is used as >> > a reference counter. This allows to avoid accidental >> > refcounter overflows that might lead to use-after-free >> > situations. >> > >> > Signed-off-by: Elena Reshetova >> > Signed-off-by: Hans Liljestrand >> > Signed-off-by: Kees Cook >> > Signed-off-by: David Windsor >> > --- >> > drivers/net/wireless/intersil/orinoco/orinoco_usb.c | 15 ++++++++------- >> > 1 file changed, 8 insertions(+), 7 deletions(-) >> >> The prefix should be "orinoco_usb:", I'll fix that. > > Thanks for both! Will you take the patches in? You mean patches 15 and 16? I didn't even look rest of the patches. But not sure yet because Dave doesn't seem to like the interface and I want to follow the discussion first. -- Kalle Valo