From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753503AbdBNMWb (ORCPT ); Tue, 14 Feb 2017 07:22:31 -0500 Received: from ozlabs.org ([103.22.144.67]:56691 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752324AbdBNMWT (ORCPT ); Tue, 14 Feb 2017 07:22:19 -0500 From: Michael Ellerman To: Pan Xinhui , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Cc: benh@kernel.crashing.org, paulus@samba.org, aneesh.kumar@linux.vnet.ibm.com, Pan Xinhui Subject: Re: [PATCH] powerpc/xmon: add turn off xmon option In-Reply-To: <1486980832-6846-1-git-send-email-xinhui.pan@linux.vnet.ibm.com> References: <1486980832-6846-1-git-send-email-xinhui.pan@linux.vnet.ibm.com> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Tue, 14 Feb 2017 23:22:14 +1100 Message-ID: <87k28tklmx.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Pan Xinhui writes: > Once xmon is triggered, there is no interface to turn it off again. > However there exists disable/enable xmon code flows. And more important, > System reset interrupt on powerVM will fire an oops to make a dump. At > that time, xmon should not be triggered. > > So add 'z' option after current 'x|X' exit commands. Turn xmon off if 'z' > is following. Thanks for trying to clear this up. But I like the solution we discussed in the other thread better. ie. entering/leaving xmon via sysrq will always leave the state unchanged, and we'll add a debugfs to change the state. cheers