From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1750791AbdAXJ6I (ORCPT <rfc822;w@1wt.eu>);
        Tue, 24 Jan 2017 04:58:08 -0500
Received: from ozlabs.org ([103.22.144.67]:35227 "EHLO ozlabs.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750732AbdAXJ6H (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 24 Jan 2017 04:58:07 -0500
From: Michael Ellerman <mpe@ellerman.id.au>
To: Greg Kurz <groug@kaod.org>, linuxppc-dev@lists.ozlabs.org
Cc: linux-kernel@vger.kernel.org,
        Frederic Barrat <fbarrat@linux.vnet.ibm.com>,
        Ian Munsie <imunsie@au1.ibm.com>
Subject: Re: [PATCH] cxl: drop unused header asm/pnv-pci.h
In-Reply-To: <148482301037.30441.14177888563610790803.stgit@bahia>
References: <148482301037.30441.14177888563610790803.stgit@bahia>
User-Agent: Notmuch/0.21 (https://notmuchmail.org)
Date: Tue, 24 Jan 2017 20:57:06 +1100
Message-ID: <87k29kaih9.fsf@concordia.ellerman.id.au>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Greg Kurz <groug@kaod.org> writes:

> The kernel API does not use anything from this header file.

That's actually hard to prove in general, because pnv-pci.h includes
linux/pci.h, linux/pci_hotplug.h, linux/irq.h, misc/cxl-base.h and
asm/opal-api.h. At least four of which aren't included directly by
api.c.

But I'll take you word for it :)

cheers

> diff --git a/drivers/misc/cxl/api.c b/drivers/misc/cxl/api.c
> index 1b35e33d2434..bcc030eacab7 100644
> --- a/drivers/misc/cxl/api.c
> +++ b/drivers/misc/cxl/api.c
> @@ -11,7 +11,6 @@
>  #include <linux/slab.h>
>  #include <linux/file.h>
>  #include <misc/cxl.h>
> -#include <asm/pnv-pci.h>
>  #include <linux/msi.h>
>  #include <linux/module.h>
>  #include <linux/mount.h>