mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Eric Anholt <eric@anholt.net>
To: Michael Zoran <mzoran@crowfest.net>, gregkh@linuxfoundation.org
Cc: swarren@wwwdotorg.org, lee@kernel.org, mzoran@crowfest.net,
	daniels@collabora.com, noralf@tronnes.org,
	weiyongjun1@huawei.com, popcornmix@gmail.com, bhumirks@gmail.com,
	stefan.wahren@i2se.com, linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: vc04_services: parse_rx_slots() - Fix compiler warning
Date: Tue, 01 Nov 2016 09:38:45 -0700	[thread overview]
Message-ID: <87k2cni296.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <20161101152114.19394-1-mzoran@crowfest.net>

[-- Attachment #1: Type: text/plain, Size: 869 bytes --]

Michael Zoran <mzoran@crowfest.net> writes:

> vc04_services contains a debug logging mechanism.  The log is
> maintained in a shared memory area between the kernel and the
> firmware.  Changing the sizes of the data in this area would
> require a firmware change which is distributed independently
> from the kernel binary.
>
> One of the items logged is the address of received messages.
> This address is a pointer, but the debugging slot used to store
> the information is a 32 bit integer.
>
> Luckily, this value is never interpreted by anything other
> then debug tools and it is expected that a human debugging
> the kernel interpret it.
>
> This change adds a cast to long before the original cast
> to int to silence the warning.
>
> Signed-off-by: Michael Zoran <mzoran@crowfest.net>

Thanks for sorting this out.

Reviewed-by: Eric Anholt <eric@anholt.net>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 800 bytes --]

      reply	other threads:[~2016-11-01 16:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-01 15:21 Michael Zoran
2016-11-01 16:38 ` Eric Anholt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k2cni296.fsf@eliezer.anholt.net \
    --to=eric@anholt.net \
    --cc=bhumirks@gmail.com \
    --cc=daniels@collabora.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=lee@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=mzoran@crowfest.net \
    --cc=noralf@tronnes.org \
    --cc=popcornmix@gmail.com \
    --cc=stefan.wahren@i2se.com \
    --cc=swarren@wwwdotorg.org \
    --cc=weiyongjun1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®