From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934759AbcATQTb (ORCPT ); Wed, 20 Jan 2016 11:19:31 -0500 Received: from canardo.mork.no ([148.122.252.1]:54458 "EHLO canardo.mork.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934680AbcATQTX convert rfc822-to-8bit (ORCPT ); Wed, 20 Jan 2016 11:19:23 -0500 From: =?utf-8?Q?Bj=C3=B8rn_Mork?= To: Michael Grzeschik Cc: mkl@pengutronix.de, wg@grandegger.com, linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH v2] can: c_can: add xceiver enable/disable support Organization: m References: <1453297443-23279-1-git-send-email-m.grzeschik@pengutronix.de> Date: Wed, 20 Jan 2016 17:19:18 +0100 In-Reply-To: <1453297443-23279-1-git-send-email-m.grzeschik@pengutronix.de> (Michael Grzeschik's message of "Wed, 20 Jan 2016 14:44:03 +0100") Message-ID: <87k2n4fcl5.fsf@nemi.mork.no> User-Agent: Gnus/5.130013 (Ma Gnus v0.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Michael Grzeschik writes: > @@ -1263,6 +1271,10 @@ int register_c_can_dev(struct net_device *dev) > */ > pinctrl_pm_select_sleep_state(dev->dev.parent); > > + priv->reg_xceiver = devm_regulator_get(priv->device, "xceiver"); > + if (IS_ERR(priv->reg_xceiver)) > + return PTR_ERR(priv->reg_xceiver); > + > c_can_pm_runtime_enable(priv); > > dev->flags |= IFF_ECHO; /* we support local echo */ Do you really want to leave priv->reg_xceiver pointing to an ERR_PTR in case of error? Bjørn