mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
	<containers@lists.linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>, <cgroups@vger.kernel.org>,
	Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [Propose] Isolate core_pattern in mnt namespace.
Date: Tue, 05 Jan 2016 01:58:34 -0600	[thread overview]
Message-ID: <87k2nopidx.fsf@x220.int.ebiederm.org> (raw)
In-Reply-To: <568B629E.5010806@cn.fujitsu.com> (Dongsheng Yang's message of "Tue, 5 Jan 2016 14:28:46 +0800")

Dongsheng Yang <yangds.fnst@cn.fujitsu.com> writes:

> On 12/24/2015 12:36 AM, Eric W. Biederman wrote:
>> Dongsheng Yang <yangds.fnst@cn.fujitsu.com> writes:
> [...]
>
> Hi Eric,
> 	Happy new year and sorry for the late reply.
>>
>> Given the other constraints on an implementation the pid namespace looks
>> by far the one best suited to host such a sysctl if it is possible to
>> implement safely.
>
> So you think it's better to isolate the core_pattern in pid_namespace,
> am I right?

Roughly.

> But, core_file_path and user_mode_helper_path in core_pattern are much
> more related with mnt_namespace IMO.
>
> Could you help to explain it more?

You need a full complement of namespaces, to execute a user mode helper.

Really roughly you need a namespaced equivalent of kthreadd, with a full
complement of namespaces and cgroups setup in the container.

Further it is necessary to have a clear rule that says which processes
that dump core are affected.    For a hierarchical pid namespace this is
straight forward.  For a mount namespace I don't know how that could be
implemented.

And yes the whole kthreadd thing that user mode helper does to launch a
task is necessary to have a clean and predicatable environment.

Of course the default rule of dropping a file named core in the current
directory of the process that died works for everyone, with no kernel
modifications needed.

Eric

      reply	other threads:[~2016-01-05  8:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-17 11:23 Dongsheng Yang
2015-12-20  2:14 ` Dongsheng Yang
2015-12-20  2:37   ` Al Viro
2015-12-20  2:47     ` Dongsheng Yang
2015-12-20  9:47       ` Eric W. Biederman
2015-12-20 23:58         ` Kamezawa Hiroyuki
2015-12-21  6:15         ` Dongsheng Yang
2015-12-21 21:52           ` Eric W. Biederman
2015-12-22  3:12             ` Kamezawa Hiroyuki
2015-12-23  3:13               ` Dongsheng Yang
2015-12-23  3:12             ` Dongsheng Yang
2015-12-23 16:36               ` Eric W. Biederman
2016-01-05  6:28                 ` Dongsheng Yang
2016-01-05  7:58                   ` Eric W. Biederman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k2nopidx.fsf@x220.int.ebiederm.org \
    --to=ebiederm@xmission.com \
    --cc=cgroups@vger.kernel.org \
    --cc=containers@lists.linux-foundation.org \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@ZenIV.linux.org.uk \
    --cc=yangds.fnst@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®