From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751339AbbJaENq (ORCPT <rfc822;w@1wt.eu>);
	Sat, 31 Oct 2015 00:13:46 -0400
Received: from mail2.asahi-net.or.jp ([202.224.39.198]:15189 "EHLO
	mail2.asahi-net.or.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750708AbbJaENo (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 31 Oct 2015 00:13:44 -0400
Date: Sat, 31 Oct 2015 13:13:38 +0900
Message-ID: <87k2q3wu8d.wl-ysato@users.sourceforge.jp>
From: Yoshinori Sato <ysato@users.sourceforge.jp>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Arnd Bergmann <arnd@arndb.de>, tglx@linutronix.de,
        linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
        Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        "open list:OPEN FIRMWARE AND..." <devicetree@vger.kernel.org>,
        "moderated list:H8/300 ARCHITECTURE" 
	<uclinux-h8-devel@lists.sourceforge.jp>
Subject: Re: [PATCH] Revert "h8300: clocksource"
In-Reply-To: <56335924.408@linaro.org>
References: <1446200775-23898-1-git-send-email-daniel.lezcano@linaro.org>
	<7633294.svub55eV7t@wuerfel>
	<56335924.408@linaro.org>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/24.5
 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=ISO-2022-JP
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 30 Oct 2015 20:48:52 +0900,
Daniel Lezcano wrote:
> 
> On 10/30/2015 12:19 PM, Arnd Bergmann wrote:
> > On Friday 30 October 2015 11:26:08 Daniel Lezcano wrote:
> >> This reverts commit 618b902d8c098f2fff188119da7b3184c4bc5483.
> 
> [ ... ]
> 
> > I found that Yoshinori Sato has always addressed all review comments very
> > quickly by rewriting the code in a proper manner when mistakes were
> > pointed out in the other drivers. Maybe you can describe now what the
> > problems are with the three drivers to give him a chance to fix them?
> 
> I agree it is a good argument to give him the opportunity to fix the code.
> 
> Yoshinori Sato, can you please do a cleanup in the init functions to
> comply with the other drivers, use CLOCKSOURCE_OF_DECLARE and remove
> the module exit code ?
> 
> Thanks.

OK.
Please wait few days.

>   -- Daniel
> 
> -- 
>  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
> 
> Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
> <http://twitter.com/#!/linaroorg> Twitter |
> <http://www.linaro.org/linaro-blog/> Blog
> 

-- 
Yoshinori Sato
<ysato@users.sourceforge.jp>