From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752904AbbJMUVu (ORCPT ); Tue, 13 Oct 2015 16:21:50 -0400 Received: from smtp01.smtpout.orange.fr ([80.12.242.123]:24542 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752522AbbJMUVt (ORCPT ); Tue, 13 Oct 2015 16:21:49 -0400 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Tue, 13 Oct 2015 22:21:48 +0200 X-ME-IP: 90.16.80.96 From: Robert Jarzmik To: Petr Cvek , Philipp Zabel Cc: daniel@zonque.org, haojian.zhuang@gmail.com, linux@arm.linux.org.uk, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 20/26] ARM: pxa: magician: Add support for MAX1587A Vcore regulator References: <5609B377.3020404@tul.cz> <1443877066.4186.38.camel@gmail.com> X-URL: http://belgarath.falguerolles.org/ Date: Tue, 13 Oct 2015 22:16:19 +0200 In-Reply-To: <1443877066.4186.38.camel@gmail.com> (Philipp Zabel's message of "Sat, 03 Oct 2015 14:57:46 +0200") Message-ID: <87k2qq4j8s.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Philipp Zabel writes: >> +static struct regulator_init_data magician_max1587a_v3_info = { >> + .constraints = { >> + .name = "vcc_core range", >> + .min_uV = 700000, >> + .max_uV = 1500000, > > Wouldn't that be 1475000 for MAX1587A without the R24 resistor? That is what I read in the Maxim 1587A datasheet, so squashed this into the patch and queued into pxa/for-next. Thanks. -- Robert