mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: Daniel Wagner <daniel.wagner@bmw-carit.de>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lib/sort: Add 64 bit swap function
Date: Mon, 27 Apr 2015 09:45:18 +0200	[thread overview]
Message-ID: <87k2wyypyp.fsf@rasmusvillemoes.dk> (raw)
In-Reply-To: <1430119606-25012-1-git-send-email-daniel.wagner@bmw-carit.de> (Daniel Wagner's message of "Mon, 27 Apr 2015 09:26:46 +0200")

On Mon, Apr 27 2015, Daniel Wagner <daniel.wagner@bmw-carit.de> wrote:

> static int cmp_32(const void *a, const void *b)
> {
> 	return (int) (*(u32 *)a - *(u32 *)b);
> }
>
> static int cmp_64(const void *a, const void *b)
> {
> 	return (int) (*(u64 *)a - *(u64 *)b);
> }
>

Please [1] don't [2] do [3] this [4].

[1] acbbe6fbb240a927ee1f5994f04d31267d422215 kcmp: fix standard comparison bug

[2] ef17af2a817db97d42dd2ec0a425231748e23dbc fs: nfsd: Fix signedness bug in compare_blob

[3] ddbc22e27e672b6b180757ea1d7f8481dbb88128 fs/hfs/catalog.c: fix comparison bug in hfs_cat_keycmp

[4] 72392ed0eb6fde96826cb9d66bd4f50a7ba61450 kernfs: Fix kernfs_name_compare

(sorry for not actually looking at the patch - this just triggered one
of my pet peeves).

Rasmus

  reply	other threads:[~2015-04-27  7:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-27  7:26 Daniel Wagner
2015-04-27  7:45 ` Rasmus Villemoes [this message]
2015-04-27  9:50   ` Daniel Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k2wyypyp.fsf@rasmusvillemoes.dk \
    --to=linux@rasmusvillemoes.dk \
    --cc=akpm@linux-foundation.org \
    --cc=daniel.wagner@bmw-carit.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®