mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: kan.liang@intel.com
Cc: acme@kernel.org, jolsa@redhat.com, linux-kernel@vger.kernel.org,
	ak@linux.intel.com
Subject: Re: [PATCH V2 1/3] perf tool: Fix perf diff symble sort issue
Date: Mon, 17 Nov 2014 14:08:18 +0900	[thread overview]
Message-ID: <87k32utnwd.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <1415653280-1374-2-git-send-email-kan.liang@intel.com> (kan liang's message of "Mon, 10 Nov 2014 16:01:18 -0500")

Hi kan,

On Mon, 10 Nov 2014 16:01:18 -0500, kan liang wrote:
> From: Kan Liang <kan.liang@intel.com>
>
> This patch fixes a bug for perf diff.
> Without mmap2, perf diff fails to find the symbol name. The default
> symbol sort key doesn't work well.
>
> Signed-off-by: Kan Liang <kan.liang@intel.com>

Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung


> ---
>  tools/perf/builtin-diff.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c
> index 25114c9..1ce425d 100644
> --- a/tools/perf/builtin-diff.c
> +++ b/tools/perf/builtin-diff.c
> @@ -357,6 +357,7 @@ static int diff__process_sample_event(struct perf_tool *tool __maybe_unused,
>  static struct perf_tool tool = {
>  	.sample	= diff__process_sample_event,
>  	.mmap	= perf_event__process_mmap,
> +	.mmap2	= perf_event__process_mmap2,
>  	.comm	= perf_event__process_comm,
>  	.exit	= perf_event__process_exit,
>  	.fork	= perf_event__process_fork,

  reply	other threads:[~2014-11-17  5:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-10 21:01 [PATCH V2 0/3] perf tool: perf diff sort changes kan.liang
2014-11-10 21:01 ` [PATCH V2 1/3] perf tool: Fix perf diff symble sort issue kan.liang
2014-11-17  5:08   ` Namhyung Kim [this message]
2014-11-10 21:01 ` [PATCH V2 2/3] perf tool:perf diff support for different binaries kan.liang
2014-11-17  5:09   ` Namhyung Kim
2014-11-10 21:01 ` [PATCH V2 3/3] perf tool: Add sort key addr for perf diff kan.liang
2014-11-17  5:27   ` Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k32utnwd.fsf@sejong.aot.lge.com \
    --to=namhyung@kernel.org \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=jolsa@redhat.com \
    --cc=kan.liang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome