mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Hitoshi Mitake <h.mitake@gmail.com>
Cc: mingo@kernel.org, linux-kernel@vger.kernel.org,
	Arnaldo Carvalho de Melo <acme@infradead.org>
Subject: Re: [PATCH] perf bench: fix confused variable namings and descriptions in mem subsystem
Date: Mon, 02 Jul 2012 10:30:31 +0900	[thread overview]
Message-ID: <87k3ynlzk8.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <1341155183-15403-1-git-send-email-h.mitake@gmail.com> (Hitoshi Mitake's message of "Mon, 2 Jul 2012 00:06:23 +0900")

Hi,

On Mon,  2 Jul 2012 00:06:23 +0900, Hitoshi Mitake wrote:
> As Namhyung Kim pointed, there are confused namings and descriptions
> of words "cycle" and "clock" in mem-memset.c and mem-memcpy.c.
>
> With the option "-c" (or "--clock", now renamed as "--cycle"), mem
> subsystem measures cost of memset() and memcpy() with cpu-cycles
> event.
>
> But current mem subsystem source code contains lots of confused
> variable namings and descriptions with "clock" (e.g. the variable
> use_clock). This is a very bad style because there is another software
> event named "cpu-clock". This patch replaces wrong usage of "clock" to
> "cycle".
>

Could you fix the Documentation/perf-bench.txt also?

Thanks,
Namhyung


  reply	other threads:[~2012-07-02  1:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-01 15:06 Hitoshi Mitake
2012-07-02  1:30 ` Namhyung Kim [this message]
2012-07-02  9:06   ` Hitoshi Mitake
2012-07-02 13:46     ` [PATCH v2] " Hitoshi Mitake
2012-07-06 11:06       ` [tip:perf/core] perf bench: Fix " tip-bot for Hitoshi Mitake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k3ynlzk8.fsf@sejong.aot.lge.com \
    --to=namhyung@kernel.org \
    --cc=acme@infradead.org \
    --cc=h.mitake@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome