mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Serge Belyshev <belyshev@depni.sinp.msu.ru>
To: Vadim Zaliva <lord@crocodile.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Johannes Berg <johannes@sipsolutions.net>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] integer overflow issue in 'appletouch' driver
Date: Sat, 07 Aug 2010 14:00:10 +0000	[thread overview]
Message-ID: <87k4o234lx.fsf@depni.sinp.msu.ru> (raw)
In-Reply-To: <20100310062227.GB2445@core.coreip.homeip.net> (Dmitry Torokhov's message of "Tue, 9 Mar 2010 22:22:27 -0800")

Hi!

Since 2.6.34 the touchpad on my feb 2005 powerbook (mod. A1106) has
stopped working. I've identified the following guilty patch:

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=04b4b88cca0ebe3813b4b6f014fb6a0db380b137

> ... Testing on one of such PowerBooks I have
> noticed that touchpad always generates positive values, but some of
> them are greater that 127, and thus, when cast to 'signed char' being
> interpreted as a negative.

My device is 05ac:020e "fountain", actually generates *signed* values,
thus the patch completely breaks it.

  reply	other threads:[~2010-08-07 14:25 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-05 19:47 Vadim Zaliva
2010-03-08  7:41 ` Johannes Berg
2010-03-09 19:43   ` Vadim Zaliva
2010-03-10  6:22     ` Dmitry Torokhov
2010-08-07 14:00       ` Serge Belyshev [this message]
2010-08-07 15:47         ` Johannes Berg
2010-08-09  0:20           ` Benjamin Herrenschmidt
2010-08-09  1:24             ` Vadim Zaliva
2010-08-09  3:43               ` Benjamin Herrenschmidt
2010-08-09 16:33                 ` Dmitry Torokhov
2010-08-09 22:36                   ` Benjamin Herrenschmidt
2018-06-20  0:24                 ` Dmitry Torokhov
2010-03-10 17:37 ` Vadim Zaliva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k4o234lx.fsf@depni.sinp.msu.ru \
    --to=belyshev@depni.sinp.msu.ru \
    --cc=dmitry.torokhov@gmail.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lord@crocodile.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®