From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755804AbYEFGaf (ORCPT ); Tue, 6 May 2008 02:30:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756548AbYEFGaH (ORCPT ); Tue, 6 May 2008 02:30:07 -0400 Received: from mail.parknet.ad.jp ([210.171.162.6]:51391 "EHLO mail.officemail.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756070AbYEFGaF (ORCPT ); Tue, 6 May 2008 02:30:05 -0400 From: OGAWA Hirofumi To: "Yinghai Lu" Cc: Greg KH , Linus Torvalds , "Ingo Molnar" , "Len Brown" , "linux-kernel\@vger.kernel.org" , linux-acpi Subject: Re: acpi_cpu_freq_init warning... References: <86802c440805051951u153ebc21p15f0d73904496217@mail.gmail.com> Date: Tue, 06 May 2008 15:29:55 +0900 In-Reply-To: <86802c440805051951u153ebc21p15f0d73904496217@mail.gmail.com> (Yinghai Lu's message of "Mon, 5 May 2008 19:51:49 -0700") Message-ID: <87k5i8hrmk.fsf@duaron.myhome.or.jp> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Anti-Virus: Kaspersky Anti-Virus for MailServers 5.5.10/RELEASE, bases: 24052007 #308098, status: clean Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > calling acpi_cpufreq_init+0x0/0x68() > sysdev: class cpu: driver (ffffffff80da0110) has already been > registered to a class, something is wrong, but will forge on! > ------------[ cut here ]------------ > WARNING: at drivers/base/sys.c:183 sysdev_driver_register+0x82/0x150() > Modules linked in: > Pid: 1, comm: swapper Not tainted > 2.6.26-rc1-sched-devel.git-x86-latest.git-00485-g253148c-dirty #333 I've seen this too. The following patch seems to work for me. -- OGAWA Hirofumi [PATCH] Fix bogus warning in sysdev_driver_register() if ((drv->entry.next != drv->entry.prev) || (drv->entry.next != NULL)) { warns list_empty(&drv->entry). Signed-off-by: OGAWA Hirofumi --- drivers/base/sys.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN drivers/base/sys.c~fix-sys-bogus-warning drivers/base/sys.c --- linux-2.6/drivers/base/sys.c~fix-sys-bogus-warning 2008-05-06 14:30:42.000000000 +0900 +++ linux-2.6-hirofumi/drivers/base/sys.c 2008-05-06 14:30:45.000000000 +0900 @@ -175,7 +175,7 @@ int sysdev_driver_register(struct sysdev } /* Check whether this driver has already been added to a class. */ - if ((drv->entry.next != drv->entry.prev) || + if ((drv->entry.next != drv->entry.prev) && (drv->entry.next != NULL)) { printk(KERN_WARNING "sysdev: class %s: driver (%p) has already" " been registered to a class, something is wrong, but " _