mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: zorgan.roman@gmail.com
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Colin Ian King <colin.i.king@gmail.com>,
	Takashi Iwai <tiwai@suse.de>,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH] ALSA: ctxfi: Fix CA20K2 S/PDIF passthrough
Date: Sun, 06 Sep 2026 10:02:43 +0200	[thread overview]
Message-ID: <87ld9e4xjw.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260903-ctxfi-spdif-conf9-fix-v1-1-5e4e3e1f801c@gmail.com>

On Thu, 03 Sep 2026 23:14:44 +0200,
Roman Prucha via B4 Relay wrote:
> 
> From: Roman Prucha <zorgan.roman@gmail.com>
> 
> dao_rsc_init() encodes the DAIO configuration as
> 
>     conf = (desc->msr & 0x7) | (desc->passthru << 3);
> 
> S/PDIF passthrough uses msr=1 and passthru=1, resulting in
> conf=9.
> 
> daio_mgr_dao_init() masks conf with 0xf, but handles only values
> 1, 2, 4 and 8 when programming ATXCTL_NUC. As a result, conf=9
> falls through to the default case and leaves NUC at its previous
> setting.
> 
> On a Creative X-Fi Titanium HD SB1270 (CA20K2), this breaks AC3
> IEC61937 passthrough when snd_ctxfi runs with
> reference_rate=48000,multiple=2. The receiver detects a non-audio
> stream but cannot decode the AC3 payload.
> 
> With the unmodified driver, multiple=1 makes the same stream work.
> Handle conf=9 through the same NUC=0 path as conf=1.
> 
> The change was runtime tested on the SB1270 with multiple=2 using
> IEC958 stereo PCM, pre-encoded AC3 IEC61937 passthrough and ALSA
> A52 live 5.1 encoding.
> 
> Fixes: 26a9630c72eb ("ALSA: ctxfi: cthw20k2: fix mask on conf to allow 4 bits")
> Cc: stable@vger.kernel.org
> Assisted-by: LLM
> Signed-off-by: Roman Prucha <zorgan.roman@gmail.com>

Applied now.  Thanks.


Takashi

      reply	other threads:[~2026-09-06  8:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-03 21:14 Roman Prucha via B4 Relay
2026-09-06  8:02 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ld9e4xjw.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=colin.i.king@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=stable@vger.kernel.org \
    --cc=tiwai@suse.com \
    --cc=zorgan.roman@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®