From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1DE43DE423 for ; Mon, 18 May 2026 09:22:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779096141; cv=none; b=PfOH50W3Z/GiT96fB/r8xDDy/FaQdyiOdKslrQO5O2ssjkTW0PhJFV/2MddPRNnQjJMFkSIxcFFq6Nl0DX0QV6YnIo1U8gp7PMsqLjOAo67svvNcOBE0cntB4vFy9FrddTU8y/nepDwH0i4JtAzlhfqiOsS6lxwULNbNEaTWMTs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779096141; c=relaxed/simple; bh=XwTgVrx2bklMiIMrHUg4G15T2KsYsT7zewWu455r+RE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=UOx23QH+dSngiAJgnPh9udL+5dA1fJ6YbuFOTEMR/mBpxD8QKjBaxLOibgfQNxkei8Qx5V+7zicqPNjat0FSa0uHajWTM5B9Dsz9GQ3FnI1bhYw3+8DU9eOz9k/V68mffZhcn9kjfBU91t3YqtXGN/0T9I1mUOp7SYERmK7oq/o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Vs/4FmWp; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=TiRYNxPz; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Vs/4FmWp"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="TiRYNxPz" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779096138; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lQO1/7FO9sTnoT11sCio/KFSKpDAF4QkGjd6FaweRXM=; b=Vs/4FmWpO2AsFohgfO25kGosxX1r8VHP6NA7L/I1YZoFjgSwid07zT3DmiY/wxoV1hUqZJ v0/YUrxlP0maScn021vqgFlZDZTLX6Hhjo+e9qHTEsoMd3TITkA0WrSE74nNmXog3y0Rr4 lv0GcuBak3lEjQ/kIdmm53or+t8TH2E= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-482-pWc0t5fENj-0Hdno5KxtGQ-1; Mon, 18 May 2026 05:22:17 -0400 X-MC-Unique: pWc0t5fENj-0Hdno5KxtGQ-1 X-Mimecast-MFC-AGG-ID: pWc0t5fENj-0Hdno5KxtGQ_1779096136 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-48fd3449e6dso13197205e9.3 for ; Mon, 18 May 2026 02:22:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779096136; x=1779700936; darn=vger.kernel.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=lQO1/7FO9sTnoT11sCio/KFSKpDAF4QkGjd6FaweRXM=; b=TiRYNxPz8EkieyUz2CAp9At1vWDnV5yJlaNiBMRNvESaIWg/Qe3ceZJ3k2k9kVEWMT sG1u1OphvxQ87uTQMIg1oXR06DKqxLj/dCuuShTWy6wgX0CkplEZdGf/vdIWYrMVLpaw 1tumgUFYUiZUe9Ow9Hi7jkM6EtV3DvBzGeDVNVB8GyxsPSczyTE2/YiZvHV3Zsi6B+eR GKZi2ZcLNKdg7RZqT+EEGhAvT0ZIP9cXTkMpvcFcppiDlIjRpZpZnI5A5IItGUdfXuDV Ha7wFvT7p+LtAyvU2jq37/4iNzmruv+AEpmGR7Et0jMi7A/QXfw9H3/e/4iifxZ0dJS4 FNYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779096136; x=1779700936; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lQO1/7FO9sTnoT11sCio/KFSKpDAF4QkGjd6FaweRXM=; b=LOBOOCvEK0NlCb5hvWE4RnyNCPv/GX4hZQUo7lzYnZqR5kxmV/P5BwSeafZ3V/7T+n 5ZdhmSTOcbXBMintJMcjLmwWbn+KHOrH8MSr/q31GaOQq5ui4IAJD4GCVFKCnxzdoWIo H4iNujeNK/RovE8iKqwADVWzQVxAlAnW5LaMROTV4TXum8J7RdiZUgrp8D8kOahIYDQF OnMvhZ8I8xwTwT8mNo2h0qAAyUxqKzh7oRR1msGnM2n0nSp0YrwrD1FyK43QkEbPpG81 2Tqkz4F2JhxgT95NCB7+jbFBxU2qNRms31X2b5P7bsMtPX8O15Q6j0Z4AWqxRUfHlwmY ca/g== X-Forwarded-Encrypted: i=1; AFNElJ9GsOIOehSuHZk5m6XCwMbRY0xxtXnb86wPCTT7ej37VG8ydpXWijxGvt+3nKbRyUZl8ebT2P9Pk/nHb6I=@vger.kernel.org X-Gm-Message-State: AOJu0Ywka/qxVRlSE2PaTFS2zuRBdnF6RFbpAtFuy5XP33e/Cnwtt7Ut FWnUoNeePbsVcWLU58PKq2QkJ8TFrqO17CU6LJkfENE64kozbmLNVAlM/zdqyhehNsdkZZJ2LXC w6mTxDcuBK2itImKO6m/sRaaiQpm/bx44FNDN9UFXcSZg6ufbwhlajhJWWMLjq3iWGw== X-Gm-Gg: Acq92OE1dR50maU3wUiQfl1oYJEVJY67DfwB/eMduLCU8QqMBrlaomdO0KRsrwfIaA5 Chjs0VwFuDlU23Ef3K4Zf/D5QH98Jb6pCoanQhdSC/judBrV6a89kvjHo82BgWBZf2/R6N1v8P4 XcWDcdToG/803oP1WRc9ak0ebDJo9BgBkxkVPOd6HGZQVi4/Cos3QpZXZiEFJJ/OEb2E/1R/PXT t8OkbH9vaHKtlx0Lj1FblyG/34XwPmXyV4uydYfVtWII3x2o3cw3YZIknN9XtWUdSGcqvTU1nR/ 5bjowwRQkSQyT1KeninR5ooU+oSwJct1ojB4J/vthP/1Vxh/uuHiGscxFTS+s4bqZUrUA8mBUKk 6ML5HRGNF4VWC0WXu04iYEuHaWmki9oN/HQns+zf68QYRKpPs8a17TjAw1fe7HiwRsxO+wcves6 MxuBRJQgtAI8NkZcY= X-Received: by 2002:a05:600c:858d:b0:488:f453:b976 with SMTP id 5b1f17b1804b1-48fe651c8b1mr148072275e9.27.1779096136183; Mon, 18 May 2026 02:22:16 -0700 (PDT) X-Received: by 2002:a05:600c:858d:b0:488:f453:b976 with SMTP id 5b1f17b1804b1-48fe651c8b1mr148071815e9.27.1779096135715; Mon, 18 May 2026 02:22:15 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48fea52a0bfsm114035395e9.0.2026.05.18.02.22.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 02:22:14 -0700 (PDT) From: Javier Martinez Canillas To: Julien Chauveau , Phong LE , Neil Armstrong , dri-devel@lists.freedesktop.org Cc: Andrzej Hajda , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Julien Chauveau Subject: Re: [PATCH] drm/bridge: it66121: acquire reset GPIO in probe In-Reply-To: <20260324193011.16583-1-chauveau.julien@gmail.com> References: <20260324193011.16583-1-chauveau.julien@gmail.com> Date: Mon, 18 May 2026 11:22:13 +0200 Message-ID: <87lddhxebe.fsf@ocarina.mail-host-address-is-not-set> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Julien Chauveau writes: Hello Julien, > The it66121_ctx structure has a gpio_reset field, and it66121_hw_reset() > calls gpiod_set_value() on it. However, the GPIO descriptor is never > acquired via devm_gpiod_get(), leaving gpio_reset as NULL throughout > the driver lifetime. > > gpiod_set_value() silently returns when passed a NULL descriptor, so > the hardware reset sequence in it66121_hw_reset() is a no-op. This > leaves the chip in an undefined state at probe time, which can prevent > it from responding on the I2C bus. > > The DT binding marks reset-gpios as a required property, so all > compliant device trees provide this GPIO. Add the missing > devm_gpiod_get() call after enabling power supplies and before the > hardware reset, so the chip is properly reset with power applied. > > Fixes: 988156dc2fc9 ("drm: bridge: add it66121 driver") > Cc: stable@vger.kernel.org > Signed-off-by: Julien Chauveau > --- The patch looks good to me. I've also tested it on my BeaglePlay board. Reviewed-by: Javier Martinez Canillas Tested-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat