From: Jonathan Corbet <corbet@lwn.net>
To: Alex Tran <alex.t.tran@gmail.com>, linus.walleij@linaro.org
Cc: linux-gpio@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, Alex Tran <alex.t.tran@gmail.com>
Subject: Re: [PATCH v2] docs: driver-api pinctrl cleanup
Date: Fri, 29 Aug 2025 15:50:19 -0600 [thread overview]
Message-ID: <87ldn14x2c.fsf@trenco.lwn.net> (raw)
In-Reply-To: <20250827074525.685863-1-alex.t.tran@gmail.com>
Alex Tran <alex.t.tran@gmail.com> writes:
> changelog:
> v2
It's best to keep this kind of stuff out of changelogs so the maintainer
doesn't have to edit it out when applying the patch. I've taken care of
it this time.
> Replace FIXME comments in the pinctrl documentation example with
> proper cleanup code:
> - Add devm_pinctrl_put() calls in error paths
> (pinctrl_lookup_state, pinctrl_select_state)
> after successful devm_pinctrl_get()
> - Set foo->p to NULL when devm_pinctrl_get() fails
> - Add ret variable for cleaner error handling
> - provides proper example of pinctrl resource management on failure
>
> Signed-off-by: Alex Tran <alex.t.tran@gmail.com>
> ---
> Documentation/driver-api/pin-control.rst | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
Applied, thanks.
jon
prev parent reply other threads:[~2025-08-29 21:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-27 7:45 Alex Tran
2025-08-28 18:30 ` Linus Walleij
2025-08-29 21:50 ` Jonathan Corbet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ldn14x2c.fsf@trenco.lwn.net \
--to=corbet@lwn.net \
--cc=alex.t.tran@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®