From: Jonathan Corbet <corbet@lwn.net>
To: SurajSonawane2415 <surajsonawane0215@gmail.com>, linux@leemhuis.info
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
SurajSonawane2415 <surajsonawane0215@gmail.com>
Subject: Re: [PATCH v4] docs: Fix grammar and phrasing errors in reporting-issues.rst
Date: Mon, 26 Aug 2024 16:05:04 -0600 [thread overview]
Message-ID: <87le0j54a7.fsf@trenco.lwn.net> (raw)
In-Reply-To: <20240816104902.123452-1-surajsonawane0215@gmail.com>
SurajSonawane2415 <surajsonawane0215@gmail.com> writes:
> Fix grammatical errors and improve phrasing in the `reporting-issues.rst`
> documentation file. These changes enhance readability and ensure the
> accuracy of the instructions provided.
>
> Signed-off-by: SurajSonawane2415 <surajsonawane0215@gmail.com>
> ---
> V3 -> V4: Adjust line wrapping to split the long line properly.
> V2 -> V3: Re-added the fix for the line: "That's why you might be need to uninstall the".
> V1 -> V2: Removed the unwanted change to the line: "try search terms like".
>
> Documentation/admin-guide/reporting-issues.rst | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
So I have been trying for a while to apply this, but have not succeeded.
It has a number of weird white-space errors. For example...
> diff --git a/Documentation/admin-guide/reporting-issues.rst b/Documentation/admin-guide/reporting-issues.rst
> index 2fd5a030235a..d0e645fc845a 100644
> --- a/Documentation/admin-guide/reporting-issues.rst
> +++ b/Documentation/admin-guide/reporting-issues.rst
> @@ -56,7 +56,7 @@ developers. It might be all that's needed for people already familiar with
> reporting issues to Free/Libre & Open Source Software (FLOSS) projects. For
> everyone else there is this section. It is more detailed and uses a
> step-by-step approach. It still tries to be brief for readability and leaves
> -out a lot of details; those are described below the step-by-step guide in a
> +out a lot of details; those are described below in the step-by-step guide in a
> reference section, which explains each of the steps in more detail.
There is a spurious space after "detail." that makes things fail.
Fixing that was not sufficient, though, there are others, and I don't
have the time to figure it all out.
Please go through the exercise of emailing the patch to yourself, and
get to the point where "git am" will accept it; then resend.
Thanks,
jon
prev parent reply other threads:[~2024-08-26 22:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-16 10:49 SurajSonawane2415
2024-08-20 5:18 ` Thorsten Leemhuis
2024-08-26 22:05 ` Jonathan Corbet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87le0j54a7.fsf@trenco.lwn.net \
--to=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@leemhuis.info \
--cc=surajsonawane0215@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®