mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Javier Martinez Canillas <javierm@redhat.com>
To: Thomas Zimmermann <tzimmermann@suse.de>, linux-kernel@vger.kernel.org
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	Arnd Bergmann <arnd@arndb.de>, Daniel Vetter <daniel@ffwll.ch>,
	David Airlie <airlied@gmail.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v3 1/3] drm: Improve Kconfig symbol prompt and help texts
Date: Mon, 03 Jul 2023 11:47:07 +0200	[thread overview]
Message-ID: <87lefxz5r8.fsf@minerva.mail-host-address-is-not-set> (raw)
In-Reply-To: <96d91373-f955-2209-5cd7-7e1ecacf73f9@suse.de>

Thomas Zimmermann <tzimmermann@suse.de> writes:

> Hi Javier
>
> Am 02.07.23 um 21:15 schrieb Javier Martinez Canillas:

[...]

>> -	  Kernel-level support for the Direct Rendering Infrastructure (DRI)
>> -	  introduced in XFree86 4.0. If you say Y here, you need to select
>> -	  the module that's right for your graphics card from the list below.
>> -	  These modules provide support for synchronization, security, and
>> -	  DMA transfers. Please see <http://dri.sourceforge.net/> for more
>> -	  details.  You should also select and configure AGP
>> -	  (/dev/agpgart) support if it is available for your platform.
>> +	  Kernel-level support for the Direct Rendering Infrastructure (DRI),
>> +	  that is composed of the Direct Rendering Manager (DRM) and Kernel
>> +	  Mode Settings (KMS) subsystems.
>
> It's slightly off, as KMS is part of DRM. I'd just drop any mention of KMS.
>
> But TBH instead of these small fixes, we should first discuss how we

Right, I'll just drop this patch and we can cleanup the text later.

> organize the menu structures. For example, the DRM drivers are all 
> listed in the graphics menu. They might as well go into a DRM menu.
>
> The framebuffer will be split into drivers and 'core'. The core options 
> (FB_DEVICE, FIRMWARE_EDID, FB_*_ENDIAN) probably deserve a separate menu.
>

Yes, that is what we agreed with Arnd and Geert. To add a new Kconfig in
drivers/video/fbdev/core/Kconfig and drivers/video/fbdev/Kconfig source it.

> And there's the framebuffer console, which has its own menu. We need to 
> show it even if only DRM is supported. Plus the other consoles.
>
> I'm not sure what drivers/auxdisplay is, it might fit here as well.
>

That seems to be for simple character-based displays. And agree that could
be in framebuffer console as well. So we should improve the menu structure
before attempting to complicate with more options like adding the FB_CORE.

> It would be nice to rethink the overall menu.
>
> Best regards
> Thomas
>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat


  reply	other threads:[~2023-07-03  9:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-02 19:15 [PATCH v3 0/3] Allow disabling all native fbdev drivers and only keeping DRM emulation Javier Martinez Canillas
2023-07-02 19:15 ` [PATCH v3 1/3] drm: Improve Kconfig symbol prompt and help texts Javier Martinez Canillas
2023-07-03  9:39   ` Thomas Zimmermann
2023-07-03  9:47     ` Javier Martinez Canillas [this message]
2023-07-02 19:15 ` [PATCH v3 2/3] fbdev: Split frame buffer support in FB and FB_CORE symbols Javier Martinez Canillas
2023-07-02 19:15 ` [PATCH v3 3/3] drm: Make FB_CORE to be selected if DRM fbdev emulation is enabled Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lefxz5r8.fsf@minerva.mail-host-address-is-not-set \
    --to=javierm@redhat.com \
    --cc=airlied@gmail.com \
    --cc=arnd@arndb.de \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®