mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Bjørn Mork" <bjorn@mork.no>
To: SZ Lin <sz.lin@moxa.com>
Cc: Johan Hovold <johan@kernel.org>, Taiyi Wu <taiyity.wu@moxa.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: serial: option: adding support for YUGA CLM920-NC5
Date: Mon, 18 Dec 2017 19:44:07 +0100	[thread overview]
Message-ID: <87lghzc1vs.fsf@miraculix.mork.no> (raw)
In-Reply-To: <20171218165248.GF3374@localhost> (Johan Hovold's message of "Mon, 18 Dec 2017 17:52:48 +0100")

Johan Hovold <johan@kernel.org> writes:

>> +static const struct option_blacklist_info yuga_clm920_nc5_blacklist = {
>> +	.reserved = BIT(0) | BIT(1) | BIT(4),
>> +};
>
> Do you really need to blacklist the first interface?

Good question. Interface #0 does look a lot like a Qualcomm DM/DIAG
function, based on two bulk endpoints, no additional descriptors and the
fact that it is the first interface.  If so, then we do want a serial
driver for it.  There is a basic libqcdm implementation in ModemManager
if you want to test it out.

And I expect interface #4 is QMI/rmnet?  Feel free to confirm that
assumption with a patch against qmi_wwan :-)


Bjørn

  reply	other threads:[~2017-12-18 18:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-15 10:32 SZ Lin
2017-12-18 16:52 ` Johan Hovold
2017-12-18 18:44   ` Bjørn Mork [this message]
2017-12-19  5:59     ` SZ Lin (林上智)
2017-12-19  6:14       ` Bjørn Mork
2017-12-19  8:54         ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lghzc1vs.fsf@miraculix.mork.no \
    --to=bjorn@mork.no \
    --cc=gregkh@linuxfoundation.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=sz.lin@moxa.com \
    --cc=taiyity.wu@moxa.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®