From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751628AbdLCKEr (ORCPT ); Sun, 3 Dec 2017 05:04:47 -0500 Received: from ozlabs.org ([103.22.144.67]:55933 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750891AbdLCKEq (ORCPT ); Sun, 3 Dec 2017 05:04:46 -0500 From: Michael Ellerman To: "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, Tetsuo Handa , Michal Hocko , Wei Wang , Jason Wang , virtualization@lists.linux-foundation.org, linux-mm@kvack.org, "linuxppc-dev\@lists.ozlabs.org" Subject: Re: Memory corruption in powerpc guests with virtio_balloon (was Re: [PATCH v3] virtio_balloon: fix deadlock on OOM) In-Reply-To: <20171201164129-mutt-send-email-mst@kernel.org> References: <1510154064-9709-1-git-send-email-mst@redhat.com> <87o9nid3zn.fsf@concordia.ellerman.id.au> <20171201164129-mutt-send-email-mst@kernel.org> Date: Sun, 03 Dec 2017 21:04:40 +1100 Message-ID: <87lgikw2iv.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "Michael S. Tsirkin" writes: > On Fri, Dec 01, 2017 at 11:31:08PM +1100, Michael Ellerman wrote: >> "Michael S. Tsirkin" writes: >> >> > fill_balloon doing memory allocations under balloon_lock >> > can cause a deadlock when leak_balloon is called from >> > virtballoon_oom_notify and tries to take same lock. ... >> >> >> Somehow this commit seems to be killing powerpc guests. ... > > Thanks for the report! > A fix was just posted: > virtio_balloon: fix increment of vb->num_pfns in fill_balloon() > > Would appreciate testing. Yep that fixes it. Thanks. Tested-by: Michael Ellerman cheers