From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751638AbdBMFil (ORCPT ); Mon, 13 Feb 2017 00:38:41 -0500 Received: from mga06.intel.com ([134.134.136.31]:62593 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751023AbdBMFik (ORCPT ); Mon, 13 Feb 2017 00:38:40 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,155,1484035200"; d="scan'208";a="43533367" From: "Huang\, Ying" To: Byungchul Park Cc: , , , , , , , , , , Subject: Re: [PATCH] llist: Don't reinvent the wheel but use existing llist API References: <1486959013-26105-1-git-send-email-byungchul.park@lge.com> Date: Mon, 13 Feb 2017 13:38:36 +0800 In-Reply-To: <1486959013-26105-1-git-send-email-byungchul.park@lge.com> (Byungchul Park's message of "Mon, 13 Feb 2017 13:10:13 +0900") Message-ID: <87lgtatztv.fsf@yhuang-dev.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Byungchul, Byungchul Park writes: > Although llist provides proper APIs, they are not used. Make them used. > > Signed-off-by: Byungchul Park > --- > drivers/md/bcache/closure.c | 15 ++------------- > drivers/md/raid5.c | 4 +--- > drivers/vhost/scsi.c | 9 ++------- > fs/file_table.c | 12 +++++------- > fs/namespace.c | 12 +++++------- > include/linux/llist.h | 3 +++ > kernel/irq_work.c | 6 +----- > kernel/sched/core.c | 13 ++----------- > mm/vmalloc.c | 8 +++----- I think you need to split the patch. One for each subsystem, this makes it easier to be reviewed and merged. Best Regards, Huang, Ying [snip]