From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758262AbcG1Nw4 (ORCPT ); Thu, 28 Jul 2016 09:52:56 -0400 Received: from ozlabs.org ([103.22.144.67]:34295 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757478AbcG1Nwv (ORCPT ); Thu, 28 Jul 2016 09:52:51 -0400 From: Michael Ellerman To: Andrew Morton Cc: Alexandre Bounine , Matt Porter , Andre van Herk , Barry Wood , linux-kernel@vger.kernel.org Subject: Re: [PATCH 11/13] rapidio: modify for rev.3 specification changes In-Reply-To: <20160727123713.8d61bed160fbfa3631b0066e@linux-foundation.org> References: <1469125134-16523-1-git-send-email-alexandre.bounine@idt.com> <1469125134-16523-12-git-send-email-alexandre.bounine@idt.com> <87vazrvfzu.fsf@concordia.ellerman.id.au> <20160727123713.8d61bed160fbfa3631b0066e@linux-foundation.org> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Thu, 28 Jul 2016 23:52:47 +1000 Message-ID: <87lh0l7tu8.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andrew Morton writes: > On Wed, 27 Jul 2016 14:53:25 +1000 Michael Ellerman wrote: >> arch/powerpc/sysdev/fsl_rio.c:702:11: error: 'struct rio_mport' has no member named 'phy_type' >> arch/powerpc/sysdev/fsl_rio.c:702:25: error: 'RIO_PHY_SERIAL' undeclared (first use in this function) > > I'll go out on a limb and assume it's this: > > --- a/arch/powerpc/sysdev/fsl_rio.c~powerpc-fsl_rio-apply-changes-for-rio-spec-rev-3-fix > +++ a/arch/powerpc/sysdev/fsl_rio.c > @@ -698,11 +698,6 @@ int fsl_rio_setup(struct platform_device > RIO_INB_ATMU_REGS_PORT2_OFFSET)); > > > - /* Set to receive any dist ID for serial RapidIO controller. */ > - if (port->phy_type == RIO_PHY_SERIAL) > - out_be32((priv->regs_win > - + RIO_ISR_AACR + i*0x80), RIO_ISR_AACR_AA); > - Yep, thanks. Hopefully someone somewhere is testing this on powerpc, I don't have one of those FSL boxes. But at least it will build now. cheers