From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752753AbcFBH2M (ORCPT ); Thu, 2 Jun 2016 03:28:12 -0400 Received: from canardo.mork.no ([148.122.252.1]:46628 "EHLO canardo.mork.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750931AbcFBH2K convert rfc822-to-8bit (ORCPT ); Thu, 2 Jun 2016 03:28:10 -0400 From: =?utf-8?Q?Bj=C3=B8rn_Mork?= To: Mario Limonciello Cc: Greg KH , hayeswang@realtek.com, LKML , Netdev , Linux USB , pali.rohar@gmail.com, anthony.wong@canonical.com Subject: Re: [PATCH] r8152: Add support for setting MAC to system's Auxiliary MAC address Organization: m References: <1464817844-27206-1-git-send-email-mario_limonciello@dell.com> <20160601230535.GA29279@kroah.com> Date: Thu, 02 Jun 2016 09:27:28 +0200 In-Reply-To: <20160601230535.GA29279@kroah.com> (Greg KH's message of "Wed, 1 Jun 2016 16:05:35 -0700") Message-ID: <87lh2oyrrz.fsf@nemi.mork.no> User-Agent: Gnus/5.130015 (Ma Gnus v0.15) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Greg KH writes: > And finally, this seems odd overall given that a MAC address should be > associated with the specific network device, not the overall system. Definitely. I wonder if this isn't a perfect candidate for an x86 arch_get_platform_mac_address() implementation? Then you could just use the eth_platform_get_mac_address() helper in the driver and avoid any platform specific code there. Which will automagically make it work as expected on a Sparc too :) This will also make your job next year much easier, when the hardeware guys decided to replace the chip and you need to implement the exact same code in some other driver... See https://patchwork.ozlabs.org/patch/564100/ for a detailed discussion of this interface. Bjørn