From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751881AbcBHOQV (ORCPT ); Mon, 8 Feb 2016 09:16:21 -0500 Received: from smtp04.smtpout.orange.fr ([80.12.242.126]:45658 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751257AbcBHOQT (ORCPT ); Mon, 8 Feb 2016 09:16:19 -0500 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Mon, 08 Feb 2016 15:16:17 +0100 X-ME-IP: 109.222.219.121 From: Robert Jarzmik To: Ulf Hansson Cc: linux-mmc , "linux-kernel\@vger.kernel.org" Subject: Re: [PATCH v2] mmc: pxamci: fix the device-tree probe deferral path References: <1454793294-7256-1-git-send-email-robert.jarzmik@free.fr> X-URL: http://belgarath.falguerolles.org/ Date: Mon, 08 Feb 2016 15:16:15 +0100 In-Reply-To: (Ulf Hansson's message of "Mon, 8 Feb 2016 10:19:12 +0100") Message-ID: <87lh6v2spc.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ulf Hansson writes: > On 6 February 2016 at 22:14, Robert Jarzmik wrote: >> When the gpio driver is probed after the mmc one, the read/write gpio >> and card detection one return -EPROBE_DEFER. Unfortunately, the memory >> region remains requested, and upon the next probe, the probe will fail >> anyway with -EBUSY. >> >> Fix this by releasing the memory resource upon probe failure. >> >> More broadly, this patch uses devm_*() primitives whenever possible in >> the probe function. > > There's actually also clocks and regulators that may be converted to > use the devm* functions. > Do you want to do that as a part of this patch as well? Otherwise I > can apply as is. Yes, I will add the regulator and clock in this patch, you're right, this makes sense to me, v3 on its way. Cheers. -- Robert