From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751947AbbJMSX3 (ORCPT ); Tue, 13 Oct 2015 14:23:29 -0400 Received: from gabe.freedesktop.org ([131.252.210.177]:56877 "EHLO gabe.freedesktop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751451AbbJMSX1 (ORCPT ); Tue, 13 Oct 2015 14:23:27 -0400 From: Eric Anholt To: Rob Herring Cc: dri-devel , "devicetree\@vger.kernel.org" , Stephen Warren , Lee Jones , "linux-kernel\@vger.kernel.org" , linux-rpi-kernel@lists.infradead.org, "linux-arm-kernel\@lists.infradead.org" Subject: Re: [PATCH v3 1/7] drm/vc4: Add devicetree bindings for VC4. In-Reply-To: References: <1444426068-15817-1-git-send-email-eric@anholt.net> <1444426068-15817-2-git-send-email-eric@anholt.net> User-Agent: Notmuch/0.20.2 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Tue, 13 Oct 2015 11:17:43 -0700 Message-ID: <87lhb63a60.fsf@eliezer.anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Rob Herring writes: > On Fri, Oct 9, 2015 at 4:27 PM, Eric Anholt wrote: >> --- >> >> v2: Extend the commit message, fix several nits from Stephen Warren. >> v3: Rename the compatibility strings, clean up node names, drop the >> unnecessary lists of components. Use compatibility strings for >> choosing CRTC HVS channel numbers. Document the HDMI clock usage. >> >> .../devicetree/bindings/gpu/brcm,bcm-vc4.txt | 64 ++++++++++++++++++++++ > > Can you put this in bindings/display/ instead? Things are moving there in 4.4. Sure. >> 1 file changed, 64 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/gpu/brcm,bcm-vc4.txt >> >> diff --git a/Documentation/devicetree/bindings/gpu/brcm,bcm-vc4.txt b/Documentation/devicetree/bindings/gpu/brcm,bcm-vc4.txt >> new file mode 100644 >> index 0000000..175bcde >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/gpu/brcm,bcm-vc4.txt >> @@ -0,0 +1,64 @@ >> +Broadcom VC4 GPU >> + >> +The VC4 device present on the Raspberry Pi includes a display system >> +with HDMI output and the HVS scaler for compositing display planes. >> + >> +Required properties for VC4: >> +- compatible: Should be "brcm,bcm2835-vc4" > > reg property? interrupts? clocks? This is the subsystem node. It has no other properties currently. >> +Required properties for Pixel Valve: >> +- compatible: Should be one of "brcm,bcm2835-pixelvalve0", >> + "brcm,bcm2835-pixelvalve1", or "brcm,bcm2835-pixelvalve2" >> +- reg: Physical base address and length of the PV's registers >> +- interrupts: The interrupt number >> + See bindings/interrupt-controller/brcm,bcm2835-armctrl-ic.txt >> + >> +Required properties for HVS: >> +- compatible: Should be "brcm,bcm2835-hvs" >> +- reg: Physical base address and length of the HVS's registers >> +- interrupts: The interrupt number >> + See bindings/interrupt-controller/brcm,bcm2835-armctrl-ic.txt >> + >> +Required properties for HDMI > > Is HDMI the only output possibility? If not, then you should have OF > graph nodes describing the connection between HDMI block and HVS (or > PV?). I'm using compatible strings for the different instances of the module: brcm,bcm2835-pixelvalve0/1/2. This lets the connections get wired up cleanly and understandably within the driver. I spent a long time trying to come up with an OF graph-based implementation, and I eventually gave up. >> +- compatible: Should be "brcm,bcm2835-hdmi" >> +- reg: Physical base address and length of the two register ranges >> + ("HDMI" and "HD", in that order) >> +- interrupts: The interrupt numbers >> + See bindings/interrupt-controller/brcm,bcm2835-armctrl-ic.txt >> +- ddc: phandle of the I2C controller used for DDC EDID probing >> +- clocks: a) hdmi: The HDMI state machine clock >> + b) pixel: The pixel clock. >> + >> +Optional properties for HDMI: >> +- hpd-gpio: The GPIO pin for HDMI hotplug detect (if it doesn't appear > > *-gpio is deprecated, so "hpd-gpios". > > Really, I think this and ddc should be in hdmi-connector binding node. > What has been done for bindings so far is all over the map though. You say hpd-gpios is deprectated, but that I should use the hdmi-connector binding that uses hpd-gpios. Which one is it? If hpd-gpios deprecated, what is supposed to be used instead? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJWHUrIAAoJELXWKTbR/J7o2uQP/0S64jmJBgB8YuAmmQb9YbPd /AMS2pe7l1/eKSvCpBBwciEREa9WGW1OucbwoQLuxckMwzdWOkSD1k4597uewvOC zqQAVQoIggcH5gy9ooAjRIcoC05Gfkns8vrW4qGAuybzbrfrxcZvLMMjSc2Y8bWx I3Cx+7k71ppOD8pUKPnzYyHhbXgr1iN722fS62XFkQo2UEl3aAV46crgqnG/Ey+x bIPEoND3s9SlBlYdUNH6E8kPAW2iMwYJehJ39DrHMMgZNfqyHzMdrf1g+BslP9Z7 PI8qhnz5w0u0wMzXQ45TVwn4nVy49dfMhMELo08wHHMOWsLIomskficdRMQ1Pboz U5HPJwCWB7PhhYRV7C2bhmfBxsXhpwxW1j+Kdi5kYmbTyu0baZe/q+yw2OtChNhl P467Ry9h6ujUvJHs6azX7DXgzXfD3/SqHA2bFpn/uAI3KS/bKLY4bZGQCeLn0RmH Al5vcKaNCGl2WnOqYA5cfDxWYifhS+1QUME9ckrDNAdAWK8GWZdmDrICgv6CHBFa 3W+LvWDCBQkazqeasO91QLrZM9PGgLhbOTvKnZXnOkfY62E2qHgSg9+ljYjd7mER HBXzAqOSg9VNZGxhL4qss5SZWoxyxlTatBOKeBcujvXNIT0+GhASd5rlRu4ewwT0 6Kcp4hs+RlgHTXmjdBiX =CcWj -----END PGP SIGNATURE----- --=-=-=--