From: Andi Kleen <andi@firstfloor.org>
To: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@infradead.org>
Subject: Re: [PATCH] perf/x86/intel/pt: Export cpu frequency ratios needed by PT decoders
Date: Fri, 28 Aug 2015 12:33:58 -0700 [thread overview]
Message-ID: <87lhcvtdg9.fsf@tassilo.jf.intel.com> (raw)
In-Reply-To: <1440687986-27246-1-git-send-email-alexander.shishkin@linux.intel.com> (Alexander Shishkin's message of "Thu, 27 Aug 2015 18:06:26 +0300")
Alexander Shishkin <alexander.shishkin@linux.intel.com> writes:
> + return sprintf(page, "%lu\n", val);
> + case 1:
> + cpuid(0x15, &eax, &ebx, &ecx, &edx);
Surely this needs to be protected by a cpuid level check?
Broadwell for once doesn't have CPUID 0x15.
-Andi
--
ak@linux.intel.com -- Speaking for myself only
next prev parent reply other threads:[~2015-08-28 19:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-27 15:06 Alexander Shishkin
2015-08-28 19:33 ` Andi Kleen [this message]
2015-08-31 12:59 ` Alexander Shishkin
2015-08-31 20:04 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lhcvtdg9.fsf@tassilo.jf.intel.com \
--to=andi@firstfloor.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@infradead.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome