From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "K. Y. Srinivasan" <kys@microsoft.com>,
devel@linuxdriverproject.org,
Haiyang Zhang <haiyangz@microsoft.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] Drivers: hv: vmbus: do cleanup on all vmbus_open() failure paths
Date: Tue, 21 Apr 2015 13:36:56 +0200 [thread overview]
Message-ID: <87lhhlbtlz.fsf@vitty.brq.redhat.com> (raw)
In-Reply-To: <20150421090508.GB14154@mwanda> (Dan Carpenter's message of "Tue, 21 Apr 2015 12:05:08 +0300")
Dan Carpenter <dan.carpenter@oracle.com> writes:
> On Tue, Apr 21, 2015 at 10:17:52AM +0200, Vitaly Kuznetsov wrote:
>> diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c
>> index 54da66d..836386f 100644
>> --- a/drivers/hv/channel.c
>> +++ b/drivers/hv/channel.c
>> @@ -186,11 +186,12 @@ int vmbus_open(struct vmbus_channel *newchannel, u32 send_ringbuffer_size,
>> list_del(&open_info->msglistentry);
>> spin_unlock_irqrestore(&vmbus_connection.channelmsg_lock, flags);
>>
>> - if (err == 0)
>> - newchannel->state = CHANNEL_OPENED_STATE;
>> + if (err != 0)
>
> Doesn't the double negative not make it slightly more confusing?
>
Point taken, will fix in v2 :-)
> regards,
> dan carpenter
--
Vitaly
next prev parent reply other threads:[~2015-04-21 11:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-21 8:17 [PATCH 0/3] Drivers: hv: vmbus: additional fixes for the setup/teardown path Vitaly Kuznetsov
2015-04-21 8:17 ` [PATCH 1/3] Drivers: hv: vmbus: do cleanup on all vmbus_open() failure paths Vitaly Kuznetsov
2015-04-21 8:35 ` Dexuan Cui
2015-04-21 11:35 ` Vitaly Kuznetsov
2015-04-21 9:05 ` Dan Carpenter
2015-04-21 11:36 ` Vitaly Kuznetsov [this message]
2015-04-21 8:17 ` [PATCH 2/3] Drivers: hv: vmbus: kill tasklets on module unload Vitaly Kuznetsov
2015-04-21 8:17 ` [PATCH 3/3] Drivers: hv: vmbus: setup irq after synic is initialized Vitaly Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lhhlbtlz.fsf@vitty.brq.redhat.com \
--to=vkuznets@redhat.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®