From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
kernel-janitors@vger.kernel.org, joe@perches.com,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/20] PCI: fix misspelling of current function in string
Date: Sun, 07 Dec 2014 21:41:28 +0100 [thread overview]
Message-ID: <87lhmj42h3.fsf@rasmusvillemoes.dk> (raw)
In-Reply-To: <1417980062-25151-4-git-send-email-Julia.Lawall@lip6.fr> (Julia Lawall's message of "Sun, 7 Dec 2014 20:20:45 +0100")
On Sun, Dec 07 2014, Julia Lawall <Julia.Lawall@lip6.fr> wrote:
> Replace a misspelled function name by %s and then __func__.
>
> The function name begins with pci, not cpci.
...
> result = cpci_hotplug_init(debug);
> if (result) {
> - err("cpci_hotplug_init with error %d\n", result);
> + err("%s with error %d\n", __func__, result);
> return result;
> }
This one seems to be a false positive; I think the err() is reporting on
the result from the call of the function which is indeed called
cpci_hotplug_init.
I just skimmed the rest quickly, but they seem ok.
Rasmus
next prev parent reply other threads:[~2014-12-07 20:41 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-07 19:20 [PATCH 0/20] " Julia Lawall
2014-12-07 19:20 ` [PATCH 1/20] mtd: s3c2410: " Julia Lawall
2014-12-07 22:48 ` Richard Weinberger
2014-12-08 7:11 ` Julia Lawall
2014-12-08 9:16 ` Richard Weinberger
2015-02-06 11:28 ` Brian Norris
2014-12-07 19:20 ` [PATCH 2/20] PCI: keystone: " Julia Lawall
2014-12-08 15:14 ` Murali Karicheri
2015-01-09 18:31 ` Bjorn Helgaas
2014-12-07 19:20 ` [PATCH 3/20] PCI: " Julia Lawall
2014-12-07 20:41 ` Rasmus Villemoes [this message]
2014-12-07 20:43 ` Julia Lawall
2014-12-07 19:20 ` [PATCH 4/20] dmfe: " Julia Lawall
2014-12-07 20:34 ` Grant Grundler
2014-12-09 21:14 ` David Miller
2014-12-07 19:20 ` [PATCH 5/20] isdn: " Julia Lawall
2014-12-09 21:14 ` David Miller
2014-12-07 19:20 ` [PATCH 6/20] TTY: " Julia Lawall
2014-12-08 8:49 ` Jiri Slaby
2014-12-08 9:18 ` Joe Perches
2014-12-08 9:50 ` Jiri Slaby
2014-12-07 19:20 ` [PATCH 7/20] drm/i915: " Julia Lawall
2014-12-08 10:24 ` Jani Nikula
2014-12-08 14:15 ` Daniel Vetter
2014-12-07 19:20 ` [PATCH 8/20] USB: isp1760: " Julia Lawall
2014-12-07 20:41 ` Jeremiah Mahler
2014-12-07 20:45 ` Julia Lawall
2014-12-07 20:48 ` Jeremiah Mahler
2014-12-07 19:20 ` [PATCH 9/20] drivers/scsi: " Julia Lawall
2014-12-07 19:20 ` [PATCH 10/20] uli526x: " Julia Lawall
2014-12-07 20:48 ` Grant Grundler
2014-12-07 20:59 ` [PATCH 10/20 v2] " Julia Lawall
2014-12-09 21:14 ` [PATCH 10/20] " David Miller
2014-12-07 19:20 ` [PATCH 11/20] vme: " Julia Lawall
2014-12-07 19:20 ` [PATCH 12/20] hp100: " Julia Lawall
2014-12-07 20:44 ` Jeremiah Mahler
2014-12-09 21:13 ` David Miller
2014-12-09 21:14 ` David Miller
2014-12-07 19:20 ` [PATCH 13/20] zd1211rw: " Julia Lawall
2014-12-07 19:20 ` [PATCH 14/20] chelsio: " Julia Lawall
2014-12-09 21:13 ` David Miller
2014-12-09 21:14 ` David Miller
2014-12-07 19:20 ` [PATCH 15/20] hostap_cs: " Julia Lawall
2014-12-07 19:20 ` [PATCH 16/20] rtlwifi: rtl8821ae: " Julia Lawall
2014-12-07 19:20 ` [PATCH 17/20] drm/i2c: tda998x: " Julia Lawall
2014-12-07 19:21 ` [PATCH 18/20] usb: gadget: " Julia Lawall
2014-12-07 19:21 ` [PATCH 19/20] TTY: " Julia Lawall
2014-12-07 20:54 ` Jeremiah Mahler
2014-12-07 21:05 ` Julia Lawall
2014-12-07 19:21 ` [PATCH 20/20] drm/radeon: " Julia Lawall
2014-12-08 15:44 ` Alex Deucher
2014-12-08 16:17 ` Julia Lawall
2014-12-07 23:44 ` [PATCH 0/20] " Julian Calaby
2014-12-08 6:43 ` Julia Lawall
2014-12-10 2:56 ` Julian Calaby
2014-12-08 3:55 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lhmj42h3.fsf@rasmusvillemoes.dk \
--to=linux@rasmusvillemoes.dk \
--cc=Julia.Lawall@lip6.fr \
--cc=bhelgaas@google.com \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®