mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Bertrand Jacquin <beber@meleeweb.net>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
	linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
	Willy Tarreau <w@1wt.eu>
Subject: Re: [PATCH 2/3] kbuild: handle module compression while running 'make modules_install'.
Date: Tue, 19 Aug 2014 06:17:58 -0700	[thread overview]
Message-ID: <87lhqkmxdl.fsf@tassilo.jf.intel.com> (raw)
In-Reply-To: <1408215016-1848-3-git-send-email-beber@meleeweb.net> (Bertrand Jacquin's message of "Sat, 16 Aug 2014 20:50:15 +0200")

Bertrand Jacquin <beber@meleeweb.net> writes:
>  
> +# CONFIG_MODULE_COMPRESS, if defined, will cause module to be compressed
> +# after they are installed in agreement with CONFIG_MODULE_COMPRESS_GZIP
> +# or CONFIG_MODULE_COMPRESS_XZ.
> +
> +mod_compress_cmd = true
> +ifdef CONFIG_MODULE_COMPRESS
> +  ifdef CONFIG_MODULE_COMPRESS_GZIP
> +    mod_compress_cmd = gzip -n -9

Please don't use gzip -9. The gain is very small, but it can make
the time to compress much longer. Just use plain gzip.

I suspect it doesn't make sense either for xz.

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only

  reply	other threads:[~2014-08-19 13:18 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-16 18:50 [PATCH 0/3] handle module compression at install Bertrand Jacquin
2014-08-16 18:50 ` [PATCH 1/3] modinst: wrap long lines in order to enhance cmd_modules_install Bertrand Jacquin
2014-08-16 18:50 ` [PATCH 2/3] kbuild: handle module compression while running 'make modules_install' Bertrand Jacquin
2014-08-19 13:17   ` Andi Kleen [this message]
2014-08-19 15:22     ` Bertrand Jacquin
2014-08-19 23:49       ` Andi Kleen
2014-08-20 15:04         ` Rusty Russell
2014-08-19 17:55     ` Rusty Russell
2014-08-19 18:54       ` Bertrand Jacquin
2014-08-16 18:50 ` [PATCH 3/3] modsign: lookup lines ending in .ko in .mod files Bertrand Jacquin
2014-08-18 21:00   ` Rusty Russell
2014-08-19 18:57 [PATCHv2 0/3] handle module compression at install Bertrand Jacquin
2014-08-19 18:57 ` [PATCH 2/3] kbuild: handle module compression while running 'make modules_install' Bertrand Jacquin
2014-08-20 16:09   ` Rusty Russell
2014-10-12 15:50   ` Andev
2014-10-12 16:40     ` Willy Tarreau
2014-10-12 17:06       ` Andev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lhqkmxdl.fsf@tassilo.jf.intel.com \
    --to=andi@firstfloor.org \
    --cc=beber@meleeweb.net \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=w@1wt.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome