mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: kpark3469@gmail.com, akpm@linux-foundation.org
Cc: keun-o.park@windriver.com, hpa@zytor.com,
	rafael.j.wysocki@intel.com, peterz@infradead.org,
	kirill.shutemov@linux.intel.com, oleg@redhat.com,
	prarit@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] earlyprintk: re-enable earlyprintk calling early_param
Date: Sat, 16 Aug 2014 04:04:13 +0930	[thread overview]
Message-ID: <87lhqp8uvu.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1408011216-8621-1-git-send-email-kpark3469@gmail.com>

kpark3469@gmail.com writes:
> From: Sahara <keun-o.park@windriver.com>
>
> Although there are many obs_kernel_param and its names are
> earlyprintk and also EARLY_PRINTK is also enabled, we could not
> see the early_printk output properly until now. This patch
> considers earlycon as well as earlyprintk.

Hmm, the initial "earlycon" hack slipped in when I wasn't looking.
I don't think we should extend it.

Why not make the thing(s) you want early_param()s?

Cheers,
Rusty.

> --- a/init/main.c
> +++ b/init/main.c
> @@ -426,7 +426,8 @@ static int __init do_early_param(char *param, char *val, const char *unused)
>  	for (p = __setup_start; p < __setup_end; p++) {
>  		if ((p->early && parameq(param, p->str)) ||
>  		    (strcmp(param, "console") == 0 &&
> -		     strcmp(p->str, "earlycon") == 0)
> +		     ((strcmp(p->str, "earlycon") == 0) ||
> +		     (strcmp(p->str, "earlyprintk") == 0)))
>  		) {
>  			if (p->setup_func(val) != 0)
>  				pr_warn("Malformed early option '%s'\n", param);
> -- 
> 1.7.9.5

  parent reply	other threads:[~2014-08-15 19:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-14 10:13 kpark3469
2014-08-14 20:34 ` Andrew Morton
2014-08-18  2:51   ` Sahara
2014-08-15 18:34 ` Rusty Russell [this message]
2014-08-18  3:13   ` Sahara
2014-08-19  2:14     ` Keun-O Park
2014-08-27 15:15 ` Thierry Reding
2014-08-29  5:28   ` Sahara
2014-08-29 15:56     ` Stephen Warren
2014-09-01  2:28       ` Sahara
2014-09-02 15:12         ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lhqp8uvu.fsf@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=akpm@linux-foundation.org \
    --cc=hpa@zytor.com \
    --cc=keun-o.park@windriver.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=kpark3469@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@redhat.com \
    --cc=peterz@infradead.org \
    --cc=prarit@redhat.com \
    --cc=rafael.j.wysocki@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome