From: Andi Kleen <andi@firstfloor.org>
To: "Yuan Pengfei" <yuanpf12@sei.pku.edu.cn>
Cc: "'Andrew Morton'" <akpm@linux-foundation.org>,
"'Peter Oberparleiter'" <oberpar@linux.vnet.ibm.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] gcov: add support for GCC 4.9
Date: Tue, 13 May 2014 20:23:36 -0700 [thread overview]
Message-ID: <87lhu53ux3.fsf@tassilo.jf.intel.com> (raw)
In-Reply-To: <000501cf6f08$7735a6a0$65a0f3e0$@sei.pku.edu.cn> (Yuan Pengfei's message of "Wed, 14 May 2014 08:07:16 +0800")
"Yuan Pengfei" <yuanpf12@sei.pku.edu.cn> writes:
> This patch handles the gcov-related changes in GCC 4.9:
> A new counter (time profile) is added. The total number is 9 now.
> A new profile merge function __gcov_merge_time_profile is added.
> See gcc/gcov-io.h and libgcc/libgcov-merge.c
> For the first change, the layout of struct gcov_info is affected.
> For the second one, a dummy function is added to kernel/gcov/base.c
> similarly.
Thanks for doing that. I tried it too at some point, but failed.
>
> +void __gcov_merge_time_profile(gcov_type *counters, unsigned int
> n_counters)
But can you repost please without word wrapping?
Except for that the patch looks good to me.
-Andi
--
ak@linux.intel.com -- Speaking for myself only
next prev parent reply other threads:[~2014-05-14 3:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-14 0:07 Yuan Pengfei
2014-05-14 3:23 ` Andi Kleen [this message]
2014-05-14 4:20 ` Yuan Pengfei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lhu53ux3.fsf@tassilo.jf.intel.com \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oberpar@linux.vnet.ibm.com \
--cc=yuanpf12@sei.pku.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®