Re: [RFC PATCH 0/2] libtraceevent/perf: Add support for trace-cmd plugins

[Namhyung Kim <namhyung@kernel.org>]

Hi, David

On Thu, 14 Jun 2012 11:35:31 -0600, David Ahern wrote:
> Now that perf is using libtraceevent and libtraceevent is based
> on trace-cmd both can be extended to leverage the plugins written
> for trace-cmd to improve pretty printing of the events.
>
> Given that it is based on code from trace-cmd I am not sure what the
> right approach is, so wanted to throw this out for comments/suggestions.
>

Yeah, it can be useful to reuse existing code for extending the
functionality. But I'm not so sure including the plugin APIs into
libtraceevent is the right thing (at least in its current form).

And for this particular case in patch 2/2, it seems that format of the
kvm_emulate_insn event is broken already and should be fixed anyway.
Further improvement in this area can be addressed in perf kvm or other
users if needed.

So I'd like to hear from others.
Arnaldo and Steven, what do you think?

Thanks,
Namhyung