From: Andi Kleen <andi@firstfloor.org>
To: Venkatesh Pallipadi <venki@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, Paul Turner <pjt@google.com>,
Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: Proper kernel irq time accounting -v3
Date: Thu, 30 Sep 2010 19:36:52 +0200 [thread overview]
Message-ID: <87lj6juo97.fsf@basil.nowhere.org> (raw)
In-Reply-To: <AANLkTimd0Acz3kcNswBoDS2XytfUgbE+ZyTxHUAcNspa@mail.gmail.com> (Venkatesh Pallipadi's message of "Thu, 30 Sep 2010 09:37:17 -0700")
Venkatesh Pallipadi <venki@google.com> writes:
>
> Yes. Overhead will be RDTSC.
> notsc is a boot option that will disable this. I didn't want to have a
notsc is a very heavy hammer.
> specific run time option to disable this as we would already have
> other RDTSC users like native_sched_clock. Do you think we need a
> specific option to disable this feature? I don't like adding a runtime
> option because it complicates the code a bit (to handle things like
> someone turning it off and turning it on later, etc).
How about some benchmarks on a known slow TSC system, like a P4?
If you can't measure it even with high interrupt loads it is probably
not relevant. If it is it would be better to have a on/off switch.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
prev parent reply other threads:[~2010-09-30 17:36 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-29 19:21 Venkatesh Pallipadi
2010-09-29 19:21 ` [PATCH 1/7] si time accounting accounts bh_disable'd time to si -v3 Venkatesh Pallipadi
2010-09-30 11:04 ` Peter Zijlstra
2010-09-30 16:26 ` Venkatesh Pallipadi
2010-10-01 23:16 ` Peter Zijlstra
2010-10-02 15:42 ` Venkatesh Pallipadi
2010-10-03 0:34 ` Peter Zijlstra
2010-10-04 16:54 ` Venkatesh Pallipadi
2010-09-29 19:21 ` [PATCH 2/7] Consolidate account_system_vtime extern declaration -v3 Venkatesh Pallipadi
2010-09-29 19:21 ` [PATCH 3/7] Add IRQ_TIME_ACCOUNTING, finer accounting of irq time -v3 Venkatesh Pallipadi
2010-09-30 11:06 ` Peter Zijlstra
2010-09-30 16:29 ` Venkatesh Pallipadi
2010-09-30 20:38 ` Venkatesh Pallipadi
2010-10-01 11:46 ` Peter Zijlstra
2010-10-01 16:51 ` Venkatesh Pallipadi
2010-10-01 17:29 ` Venkatesh Pallipadi
2010-10-01 23:14 ` Peter Zijlstra
2010-10-01 23:32 ` Venkatesh Pallipadi
2010-10-02 10:53 ` Peter Zijlstra
2010-10-02 15:26 ` Venkatesh Pallipadi
2010-10-03 0:26 ` Peter Zijlstra
2010-10-01 11:45 ` Peter Zijlstra
2010-09-29 19:21 ` [PATCH 4/7] x86: Add IRQ_TIME_ACCOUNTING in x86 -v3 Venkatesh Pallipadi
2010-09-29 19:21 ` [PATCH 5/7] sched: Do not account irq time to current task -v3 Venkatesh Pallipadi
2010-09-29 19:21 ` [PATCH 6/7] sched: Remove irq time from available CPU power -v3 Venkatesh Pallipadi
2010-09-29 19:21 ` [PATCH 7/7] Export per cpu hardirq and softirq time in proc -v3 Venkatesh Pallipadi
2010-09-30 7:59 ` Proper kernel irq time accounting -v3 Andi Kleen
2010-09-30 16:37 ` Venkatesh Pallipadi
2010-09-30 17:36 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lj6juo97.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=eric.dumazet@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=tglx@linutronix.de \
--cc=venki@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome