From: Andi Kleen <andi@firstfloor.org>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Robert Richter <robert.richter@amd.com>,
Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [2.6.28-rc6] oprofile: "opcontrol --start" output two warnings
Date: Tue, 25 Nov 2008 11:09:08 +0100 [thread overview]
Message-ID: <87ljv8ce2j.fsf@basil.nowhere.org> (raw)
In-Reply-To: <20081125121212.26C3.KOSAKI.MOTOHIRO@jp.fujitsu.com> (KOSAKI Motohiro's message of "Tue, 25 Nov 2008 12:18:22 +0900 (JST)")
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> writes:
>
> Index: b/arch/x86/oprofile/op_model_p4.c
> ===================================================================
> --- a/arch/x86/oprofile/op_model_p4.c 2008-11-24 06:20:04.000000000 +0900
> +++ b/arch/x86/oprofile/op_model_p4.c 2008-11-24 06:29:09.000000000 +0900
> @@ -399,6 +399,8 @@ static void p4_fill_in_addresses(struct
> unsigned int i;
> unsigned int addr, cccraddr, stag;
>
> + get_cpu();
The whole thing seems broken anyways because the only caller of
fill_in_addresses only assigns to CPU 0 and fill_in_addresses only
runs on some CPU. So I guess the stagger handling could be just
removed because it's useless.
-Andi
--
ak@linux.intel.com
next prev parent reply other threads:[~2008-11-25 10:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-25 3:18 KOSAKI Motohiro
2008-11-25 10:09 ` Andi Kleen [this message]
2008-11-25 10:29 ` KOSAKI Motohiro
2008-11-25 11:09 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ljv8ce2j.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=robert.richter@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®