From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Don't pass offset == 0 && endbyte == 0 to do_sync_file_range()
Date: Sun, 02 Apr 2006 11:21:23 +0900 [thread overview]
Message-ID: <87lkuozpi4.fsf@duaron.myhome.or.jp> (raw)
In-Reply-To: <20060401180559.450f20b2.akpm@osdl.org> (Andrew Morton's message of "Sat, 1 Apr 2006 18:05:59 -0800")
Andrew Morton <akpm@osdl.org> writes:
>> + /*
>> + * wbc->start == 0 && wbc->end == 0 is a special range,
>> + * so this avoids using it.
>> + */
>> + if (endbyte > 1)
>> + endbyte--; /* inclusive */
>> + }
>
> Yes, the problem is that the interface is busted - start=0,end=0 is
> ambiguous and ->writepages() will get it wrong.
>
> So I think it's better to fix the interface...
I agree. And I think WB_SYNC_NONE with rage would be useful.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
prev parent reply other threads:[~2006-04-02 2:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-01 21:22 OGAWA Hirofumi
2006-04-02 2:05 ` Andrew Morton
2006-04-02 2:21 ` OGAWA Hirofumi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lkuozpi4.fsf@duaron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®