From: Takashi Iwai <tiwai@suse.de>
To: Sreeraj S Kurup <sreekuttan2156239@gmail.com>
Cc: tiwai@suse.de, linux-kernel@vger.kernel.org,
linux-sound@vger.kernel.org, perex@perex.cz, tiwai@suse.com
Subject: Re: [PATCH v2] ALSA: control: Synchronize LED mode accesses
Date: Sat, 07 Nov 2026 14:59:13 +0100 [thread overview]
Message-ID: <87mrrkyc7i.wl-tiwai@suse.de> (raw)
In-Reply-To: <20261107121235.3521-1-sreekuttan2156239@gmail.com>
On Sat, 07 Nov 2026 13:12:35 +0100,
Sreeraj S Kurup wrote:
>
> Hi Takashi,
>
> I would like to kindly follow up on my first patch.
>
> Could you please let me know if you have had a chance to review it?
>
> For reference, here is the patch link:
> https://lore.kernel.org/all/20261106162357.3616-1-sreekuttan2156239@gmail.com/
I'm still considering what's the best way.
Your patch replaces and adds some open-code, which isn't nice.
OTOH, it's a small change, so it's acceptable.
An alternative would be to use simple_strtoul() that can return the
end pointer. Or, we may reorganize the whole code a bit, so that to
get the delimiter at first (instead of the head of the next word),
then clear and parse. But not sure whether it'd be worth.
Takashi
prev parent reply other threads:[~2026-11-07 13:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-06 18:08 [PATCH] " Sreeraj S Kurup
2026-11-06 18:39 ` [PATCH v2] " Sreeraj S Kurup
2026-11-07 9:09 ` Takashi Iwai
2026-11-07 11:55 ` [PATCH] " Sreeraj S Kurup
2026-11-07 11:59 ` [PATCH v2] " Sreeraj S Kurup
2026-11-07 12:12 ` Sreeraj S Kurup
2026-11-07 13:59 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mrrkyc7i.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=sreekuttan2156239@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®