From: Takashi Iwai <tiwai@suse.de>
To: Rafael Medina <rafael@gexdigital.net>
Cc: Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
Devin Christensen <dchristensen8@proton.me>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/ca0132: Restore AE-5 audio registers after LED strip send
Date: Wed, 04 Nov 2026 08:28:11 +0100 [thread overview]
Message-ID: <87mrrpukc4.wl-tiwai@suse.de> (raw)
In-Reply-To: <20261102225723.123266-1-rafael@gexdigital.net>
On Mon, 02 Nov 2026 23:57:23 +0100,
Rafael Medina wrote:
>
>
> The AE-5 LED strip transport added by commit c3e35f355fad ("ALSA:
> hda/ca0132: Add Sound BlasterX AE-5 external RGB LED strip support")
> reprograms the CA0113 audio serializer block in BAR2 to clock out the
> WS2812 data, and at the end clears only the stream routing register.
> The format and channel enable register at 0x100 is left at 0x3000ff8f
> instead of the 0x00000700 it reads after a normal codec init, and the
> analog outputs stay silent until the codec is initialised again.
>
> The strip control is marked volatile, but alsactl still stores it, and
> the udev rule runs "alsactl restore" for every card probe. The saved
> state of a card that never had a strip attached contains "AE-5 LED
> Strip" and "AE-5 LED Strip Count" with access "read write volatile".
> ae5_strip_ctl_put() sent a frame even when the colors were unchanged,
> so every boot of an AE-5 or AE-5 Plus ended with a silent card.
>
> Save the registers that the transmit touches before programming them
> and write them back at the end of ae5_strip_send_frame(), and do not
> transmit from ae5_strip_ctl_put() when the colors did not change.
>
> Fixes: c3e35f355fad ("ALSA: hda/ca0132: Add Sound BlasterX AE-5 external RGB LED strip support")
> Cc: Devin Christensen <dchristensen8@proton.me>
> Signed-off-by: Rafael Medina <rafael@gexdigital.net>
Applied now. Thanks.
Takashi
prev parent reply other threads:[~2026-11-04 7:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 22:57 Rafael Medina
2026-11-04 7:28 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mrrpukc4.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=dchristensen8@proton.me \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=rafael@gexdigital.net \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®