From: Takashi Iwai <tiwai@suse.de>
To: d@zerovolt.org
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: usb-audio: Add feedback snap quirk for Mayflower ARC AMP
Date: Fri, 09 Oct 2026 15:26:26 +0200 [thread overview]
Message-ID: <87mrsn3szh.wl-tiwai@suse.de> (raw)
In-Reply-To: <20261009-mayflower-fb-v1-1-a84e82e05ac9@zerovolt.org>
On Fri, 09 Oct 2026 13:44:53 +0200,
Dimitri Wegner via B4 Relay wrote:
>
> From: Dimitri Wegner <d@zerovolt.org>
>
> The Mayflower ARC AMP DAC (USB ID 0493:4170, MAG Technology front-end)
> at times gets stuck reporting feedback of nominal+1 sample/frame (97
> instead of 96 at 96 kHz) and does not recover. The driver follows this
> feedback, and audible pops occur every 1-2s until the stream is
> restarted.
>
> Add a quirk for this device that ignores feedback values more than
> 1/128 (~0.8%) away from nominal and uses the nominal rate instead.
> Normal feedback corrections are far smaller than that and pass
> through unchanged. Other devices are not affected.
>
> Signed-off-by: Dimitri Wegner <d@zerovolt.org>
> ---
> Tested on this DAC at 96 kHz for ~10 weeks on kernels 7.1 and 7.2.
> The pops no longer occur. The quirk triggered ~680 times over that
> period, always with feedback 0x61.0000 against nominal 0x60.0000.
OK, so I assume that dev_warn_ratelimited() isn't too annoying, then.
Applied to for-next branch now. Thanks.
Takashi
prev parent reply other threads:[~2026-10-09 13:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-09 11:44 Dimitri Wegner via B4 Relay
2026-10-09 13:26 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mrsn3szh.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=d@zerovolt.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®