mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Mark Brown <broonie@kernel.org>
Cc: Richard Weinberger <richard@nod.at>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	 Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	linux-spi@vger.kernel.org,  linux-kernel@vger.kernel.org,
	linux-mtd@lists.infradead.org,  Michael Walle <mwalle@kernel.org>,
	Takahiro Kuwano <takahiro.kuwano@infineon.com>,
	 Pratyush Yadav <pratyush@kernel.org>,
	 Steam Lin <STLin2@winbond.com>,  Santhosh Kumar K <s-k6@ti.com>
Subject: Re: [PATCH 0/4] spi: spi-mem/mtd: spinand: Prevent SPI NAND continuous reads on am65/am62
Date: Mon, 28 Sep 2026 16:51:21 +0200	[thread overview]
Message-ID: <87mrt177km.fsf@bootlin.com> (raw)
In-Reply-To: <878qa7dzke.fsf@bootlin.com> (Miquel Raynal's message of "Tue, 28 Apr 2026 14:44:33 +0200")

Hello Mark,

On 28/04/2026 at 14:44:33 +02, Miquel Raynal <miquel.raynal@bootlin.com> wrote:

> On 26/03/2026 at 17:47:14 +01, Miquel Raynal <miquel.raynal@bootlin.com> wrote:
>
>> TI errata i2351 explains there is a problem with CS handling, SPI NOR
>> are immune to the problem, but the CS being deasserted spuriously when
>> there is DMA arbitration on long accesses (every 1023 bytes), SPI NAND
>> continuous reads cannot be leveraged.
>>
>> Link: https://www.ti.com/lit/er/sprz544c/sprz544c.pdf
>>
>> I created a 2-page read setup for testing all variants available on a
>> W35N chip wired to this controller. I reliably observed all variants to
>> always (in my tests) report correct data, except the 8D-8D-8D
>> variant *when setting an extended number of dummy cycles* (>= 12, so 24
>> dummy bytes). In this case, I got the first 6144 bytes correct (over
>> 8192), the rest being full of ones (0xFF), indicating the CS has likely
>> been deasserted there. This is not exactly 6 x 1023 bytes (?), but
>> close.
>>
>> This series shall be applied on top of the SPI NAND continuous read
>> series that I am also carrying, but ideally not too far in the future
>> because there are Winbond (continuous read capable) NAND chips mounted
>> on TI platforms AM62 based which could make use of that new feature and
>> expose the issue described above.
>
> Applied to nand/next (except the spi patch).

It seems like the spi bits have not been applied, can you check if you
can still apply them? Without these, people using this controller with
continuous read capable devices may observe spurious issues hard to
debug (due to the CS possibly not being kept asserted during long reads,
leading to the continuous read being cancelled by the SPI NAND).

Thanks,
Miquèl

  reply	other threads:[~2026-09-28 14:51 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-26 16:47 Miquel Raynal
2026-03-26 16:47 ` [PATCH 1/4] spi: spi-mem: Add a no_cs_assertion capability Miquel Raynal
2026-04-27 23:46   ` Mark Brown
2026-06-10  7:00   ` Michael Walle
2026-03-26 16:47 ` [PATCH 2/4] mtd: spinand: Make sure continuous read is always disabled during probe Miquel Raynal
2026-03-26 16:47 ` [PATCH 3/4] mtd: spinand: Prevent continuous reads on some controllers Miquel Raynal
2026-03-26 16:47 ` [PATCH 4/4] spi: cadence-qspi: Prevent SPI NAND continuous reads Miquel Raynal
2026-06-10  6:03   ` Santhosh Kumar K
2026-04-27 13:28 ` [PATCH 0/4] spi: spi-mem/mtd: spinand: Prevent SPI NAND continuous reads on am65/am62 Miquel Raynal
2026-04-27 23:45   ` Mark Brown
2026-04-28 12:44 ` Miquel Raynal
2026-09-28 14:51   ` Miquel Raynal [this message]
2026-09-28 15:08     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mrt177km.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=STLin2@winbond.com \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=mwalle@kernel.org \
    --cc=pratyush@kernel.org \
    --cc=richard@nod.at \
    --cc=s-k6@ti.com \
    --cc=takahiro.kuwano@infineon.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®