From: Jonathan Corbet <corbet@lwn.net>
To: Omokefe Emmanuel Onanaroghene <emmaonana18@gmail.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org
Cc: skhan@linuxfoundation.org, rdunlap@infradead.org,
mchehab@kernel.org, aleksander.lobakin@intel.com,
aleksandr.loktionov@intel.com, tudor.ambarus@linaro.org,
emmaonana18@gmail.com, bvanassche@acm.org
Subject: Re: [PATCH] docs: kdoc: fix struct_group_tagged() parsing regression
Date: Tue, 15 Sep 2026 12:50:50 -0600 [thread overview]
Message-ID: <87mrti9wmt.fsf@trenco.lwn.net> (raw)
In-Reply-To: <20260914155127.21515-1-emmaonana18@gmail.com>
Omokefe Emmanuel Onanaroghene <emmaonana18@gmail.com> writes:
> kernel-doc reports struct_group_tagged() members as excess because
> the macro transformation rewrites it to an anonymous struct and drops their
> member names.
>
> Keep the tag and member name when transforming struct_group_tagged(). The
> nested members are then recorded as names such as fast.order; accept the
> existing unqualified @order documentation tag during validation.
>
> Add a regression test based on struct page_pool_params.
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Link: https://lore.kernel.org/all/0cf8ea5f-418f-45f0-907c-3d1ed4f03e9f@infradead.org/
> Fixes: 2f07ddbd5793 ("docs: xforms_lists: better evaluate struct_group macros")
> Signed-off-by: Omokefe Emmanuel Onanaroghene <emmaonana18@gmail.com>
> ---
> tools/lib/python/kdoc/kdoc_parser.py | 4 ++-
> tools/lib/python/kdoc/xforms_lists.py | 2 +-
> tools/unittests/test_kdoc_parser.py | 37 +++++++++++++++++++++++++++
> 3 files changed, 41 insertions(+), 2 deletions(-)
This seems perhaps a reasonable fix. Did you write this on your own, or
was there an LLM involved?
Thanks,
jon
next prev parent reply other threads:[~2026-09-15 18:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-14 15:51 Omokefe Emmanuel Onanaroghene
2026-09-14 17:20 ` Randy Dunlap
2026-09-15 18:50 ` Jonathan Corbet [this message]
2026-09-16 20:45 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mrti9wmt.fsf@trenco.lwn.net \
--to=corbet@lwn.net \
--cc=aleksander.lobakin@intel.com \
--cc=aleksandr.loktionov@intel.com \
--cc=bvanassche@acm.org \
--cc=emmaonana18@gmail.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=skhan@linuxfoundation.org \
--cc=tudor.ambarus@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®