From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Xuanqiang Luo <xuanqiang.luo@linux.dev>
Cc: linux-wpan@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, alex.aring@gmail.com,
stefan@datenfreihafen.org, david.girault@qorvo.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, horms@kernel.org, stable@vger.kernel.org,
Xuanqiang Luo <luoxuanqiang@kylinos.cn>
Subject: Re: [PATCH net v1] mac802154: avoid extra skb references in RX queues
Date: Mon, 07 Sep 2026 08:30:58 +0200 [thread overview]
Message-ID: <87mrtty3ml.fsf@bootlin.com> (raw)
In-Reply-To: <20260905061524.91223-1-xuanqiang.luo@linux.dev> (Xuanqiang Luo's message of "Sat, 5 Sep 2026 14:15:23 +0800")
On 05/09/2026 at 14:15:23 +08, Xuanqiang Luo <xuanqiang.luo@linux.dev> wrote:
> From: Xuanqiang Luo <luoxuanqiang@kylinos.cn>
>
> __ieee802154_rx_handle_packet() passes each cloned skb to
> ieee802154_subif_frame() and does not release it after the call. The
> callee consumes the skb on every path: it either frees it, hands it to
> the networking stack, or stores it in a queued RX descriptor.
>
> The beacon and MAC command paths nevertheless call skb_get() before
> storing the skb. The worker drops only that additional reference, leaving
> the original clone reference without an owner and leaking every queued
> skb.
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
prev parent reply other threads:[~2026-09-07 6:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-05 6:15 Xuanqiang Luo
2026-09-07 6:30 ` Miquel Raynal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mrtty3ml.fsf@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=alex.aring@gmail.com \
--cc=davem@davemloft.net \
--cc=david.girault@qorvo.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=luoxuanqiang@kylinos.cn \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
--cc=stefan@datenfreihafen.org \
--cc=xuanqiang.luo@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®