From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 602E9EB64DD for ; Sat, 22 Jul 2023 00:14:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230376AbjGVAOD (ORCPT ); Fri, 21 Jul 2023 20:14:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229529AbjGVAOB (ORCPT ); Fri, 21 Jul 2023 20:14:01 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9946410CB for ; Fri, 21 Jul 2023 17:13:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689984800; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9zAUVsITJjQgJMe+wUauASsmwQ/Teft8FD3ucSilGuQ=; b=EC2FjVcYajejlMjQg1CMiQdZIco+eJ9yTWQDgQFqcTeAOQlErW7tU9n8vGRXM2kUWDC/x5 OLz3tVDzH5uhWhGWg+jcaaEcgEP2U6WGne+5CbqJAg+CWaI9gM2JItfVm1iDUKDchqu0LM Z3f8MJhp5GbmaIveE5dkJLifqvmYzjU= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-587-BCn7wMvlPC65ajC2KReeHQ-1; Fri, 21 Jul 2023 20:13:18 -0400 X-MC-Unique: BCn7wMvlPC65ajC2KReeHQ-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3144bf68a03so1294127f8f.2 for ; Fri, 21 Jul 2023 17:13:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689984797; x=1690589597; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9zAUVsITJjQgJMe+wUauASsmwQ/Teft8FD3ucSilGuQ=; b=PTZ3rOe8MYPxVPwNT6iAGi2OM291hkl/oYt2XuLA5MzYQPqiTLcBqaMNcxWhNL+auC NuQLJfv1whXoag+PiLCa6lk+PzH2ohJLUuhGsFVxkLE+Dsahd9yzXSkIdMJBYvePZplO 2LBtOos+3dUvWDROUlNzQp+LzdHw8ChSi8HKYWGGnqW51yEzjz92o17i7kwVuGFSQ8Zf gzFI9wVYLSZTVU8auDh9GBOOm+fNFJ6j8a/Dzx7Gy6WkGA5JmnmvO0EGBkp6dF0n1ktz BI4XrKbhyx3X3lfS6MelxPVg77J5plxlFjH6VglbuRWuVXS+IrbrVkuKpikColKv4h8U BUcQ== X-Gm-Message-State: ABy/qLb920cgUKLxDA5qlldmf2TKDvN4xAVU7kXhfGVFQkpXj0PRCW92 mNIRae0C7ENhnFU5GY8TB65kpd4A4ztEagAn7LGjzFaJ6cdSeYGdevIWUBRiZyzlnK560dpmeII tturfxi4ZuUzUFv4TodMpKlaStTEa4Wb2 X-Received: by 2002:a05:600c:20d1:b0:3fd:1daf:abd8 with SMTP id y17-20020a05600c20d100b003fd1dafabd8mr2089746wmm.40.1689984797569; Fri, 21 Jul 2023 17:13:17 -0700 (PDT) X-Google-Smtp-Source: APBJJlEXRkyrt5UhsSX2MfCaQiSDHQSKHbh/kU/IrA6UfVzAbLX+sn0IQirVDLsddlSuFOcFPpbQDw== X-Received: by 2002:a05:600c:20d1:b0:3fd:1daf:abd8 with SMTP id y17-20020a05600c20d100b003fd1dafabd8mr2089733wmm.40.1689984797253; Fri, 21 Jul 2023 17:13:17 -0700 (PDT) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id u9-20020a05600c210900b003fbcdba1a52sm6920280wml.3.2023.07.21.17.13.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jul 2023 17:13:16 -0700 (PDT) From: Javier Martinez Canillas To: Miguel Ojeda Cc: linux-kernel@vger.kernel.org, Miguel Ojeda , Thomas Zimmermann , Geert Uytterhoeven , Arnd Bergmann , Greg Kroah-Hartman , Helge Deller , Jacek Lawrynowicz , Jeffrey Hugo , Nipun Gupta , Oded Gabbay , Pieter Jansen van Vuuren , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH v6 1/4] video: Add auxiliary display drivers to Graphics support menu In-Reply-To: References: <20230719081544.741051-1-javierm@redhat.com> <20230719081544.741051-2-javierm@redhat.com> <87sf9gublz.fsf@minerva.mail-host-address-is-not-set> Date: Sat, 22 Jul 2023 02:13:16 +0200 Message-ID: <87mszou7kz.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Miguel Ojeda writes: Hello Miguel, > On Sat, Jul 22, 2023 at 12:46=E2=80=AFAM Javier Martinez Canillas > wrote: >> >> Javier Martinez Canillas writes: >> >> [adding Miguel Ojeda who was not in the Cc list] >> >> Hello Miguel, could you please ack this patch so that I can take the who= le >> patch-set through the drm-misc tree? > > A note below... > >> > The drivers in this subsystem are for character-based LCD displays, wh= ich >> > can fall into the same category of the DRM/KMS and fbdev drivers that = are >> > located under the "Graphics support" menu. Add auxdisplay there as wel= l. > > Nit: this is not exactly true, e.g. ks0108/cfag12864b (which were the > first in the subsystem) were not character-based but a very simple > black-or-white 128x64 grid, so we should probably reword slightly > this. > Oh, interesting. I wonder why that couldn't had been a fbdev driver then using FB_VISUAL_MONO01? I'll reword then the commit message before apply to the following instead: "The drivers in this subsystem are for either character-based or monochrome LCD controllers, which can fall into the same category of the DRM/KMS and fbdev drivers, that are located under the "Graphics support" menu. Add the auxdisplay drivers there as well to have all display drivers under the same menu." > In any case, if Helge thinks these may belong in the "Graphics > support" menu, then I am fine with it: > > Acked-by: Miguel Ojeda > Perfect, thanks! > Thanks! > > Cheers, > Miguel > --=20 Best regards, Javier Martinez Canillas Core Platforms Red Hat