From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A650C43461 for ; Sun, 13 Sep 2020 15:34:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E38E52078D for ; Sun, 13 Sep 2020 15:34:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600011255; bh=U7j8lScFgpuEW/6fVOIsPgZrSsqPIYFR9iMMpABDa4g=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=LnlE2u5NjJ+g7VbSmNmHyhHcrzO4nYgmyprHrut4H+4yfFUJjIuYT6x5bldUP79vl /9M+1NhGuw90EtyICSm/a9JNulTzLam7s+wc0+t14Ojjh4OWnnFPrclntZ6kGubcjM eCLPLr11ihhTbm+o4Ve4D3+l7K32DN3qAia/FK8A= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725958AbgIMPeL (ORCPT ); Sun, 13 Sep 2020 11:34:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:37176 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725938AbgIMPeJ (ORCPT ); Sun, 13 Sep 2020 11:34:09 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5D6EF2078D; Sun, 13 Sep 2020 15:34:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600011248; bh=U7j8lScFgpuEW/6fVOIsPgZrSsqPIYFR9iMMpABDa4g=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=0Wtk1MMYl2QoNCwq4dh2Ew5BgyQLdcbHQF5C59Ra2Guz9bP1QpQO2MYOZP+IsmbMk L5p0JedGxSNbbxu3WUzHqsI0gFpP/+cYUFo4a+DCzg93Pt7ScX76ZHJ3bz6w24olTZ ihF2F3PjHpCDytx6DdNfi5pHknqd53YMkAcZtNbw= Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kHU10-00BSHc-8H; Sun, 13 Sep 2020 16:34:06 +0100 Date: Sun, 13 Sep 2020 16:34:05 +0100 Message-ID: <87mu1tr8r6.wl-maz@kernel.org> From: Marc Zyngier To: Krzysztof Kozlowski Cc: Nishanth Menon , Tero Kristo , Santosh Shilimkar , Thomas Gleixner , Jason Cooper , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] irqchip/ti-sci-inta: Fix kerneldoc In-Reply-To: <20200902174615.24695-2-krzk@kernel.org> References: <20200902174615.24695-1-krzk@kernel.org> <20200902174615.24695-2-krzk@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/26.3 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: krzk@kernel.org, nm@ti.com, t-kristo@ti.com, ssantosh@kernel.org, tglx@linutronix.de, jason@lakedaemon.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 02 Sep 2020 18:46:15 +0100, Krzysztof Kozlowski wrote: > > Fix kerneldoc W=1 warnings: > > drivers/irqchip/irq-ti-sci-inta.c:144: warning: Function parameter or member 'vint_id' not described in 'ti_sci_inta_xlate_irq' > drivers/irqchip/irq-ti-sci-inta.c:144: warning: Excess function parameter 'irq' description in 'ti_sci_inta_xlate_irq' > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/irqchip/irq-ti-sci-inta.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/irqchip/irq-ti-sci-inta.c b/drivers/irqchip/irq-ti-sci-inta.c > index bc863ef7998d..84929f3e2003 100644 > --- a/drivers/irqchip/irq-ti-sci-inta.c > +++ b/drivers/irqchip/irq-ti-sci-inta.c > @@ -134,7 +134,7 @@ static void ti_sci_inta_irq_handler(struct irq_desc *desc) > /** > * ti_sci_inta_xlate_irq() - Translate hwirq to parent's hwirq. > * @inta: IRQ domain corresponding to Interrupt Aggregator > - * @irq: Hardware irq corresponding to the above irq domain > + * @vint_id: TISCI vint ID I'm not sure that replacing a flaky variable name with something that is essentially unintelligible is a huge improvement. M. -- Without deviation from the norm, progress is not possible.