From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2C30C2BA19 for ; Mon, 6 Apr 2020 13:02:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C57BE22273 for ; Mon, 6 Apr 2020 13:02:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="PHPHD7F5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728286AbgDFNCW (ORCPT ); Mon, 6 Apr 2020 09:02:22 -0400 Received: from mail26.static.mailgun.info ([104.130.122.26]:15198 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728184AbgDFNCV (ORCPT ); Mon, 6 Apr 2020 09:02:21 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1586178141; h=Content-Transfer-Encoding: Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=9tdkGmLU02zbWVLGYy5PSq5hUqznxpWzvhiGLCd+WxU=; b=PHPHD7F5iV/9XLu+ktllJkG/YqwfVXeT/GNqiukILWOlULfRydUZE3OCVeseOE3nvxCkHc/1 xViWn0yqj9XCgdvQJSFvbgZt3Z5Qkw5+2A2HksBNsR6k+n3Cn8fZuIIF7uloz5Vmdf+tA02l OFXgnVkheGMZLzkUxf9z67HpmWI= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e8b2855.7f0ef81547d8-smtp-out-n03; Mon, 06 Apr 2020 13:02:13 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 75195C433F2; Mon, 6 Apr 2020 13:02:13 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 28F6BC433D2; Mon, 6 Apr 2020 13:02:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 28F6BC433D2 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: YueHaibing Cc: , , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ath11k: thermal: Fix build error without CONFIG_THERMAL References: <20200403083414.31392-1-yuehaibing@huawei.com> Date: Mon, 06 Apr 2020 16:02:07 +0300 In-Reply-To: <20200403083414.31392-1-yuehaibing@huawei.com> (yuehaibing@huawei.com's message of "Fri, 3 Apr 2020 16:34:14 +0800") Message-ID: <87mu7ozs1c.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org YueHaibing writes: > drivers/net/wireless/ath/ath11k/thermal.h:45:1: > warning: no return statement in function returning non-void [-Wreturn-ty= pe] > drivers/net/wireless/ath/ath11k/core.c:416:28: error: > passing argument 1 of =E2=80=98ath11k_thermal_unregister=E2=80=99 from i= ncompatible pointer type [-Werror=3Dincompatible-pointer-types] > > Add missing return 0 in ath11k_thermal_set_throttling, > and fix ath11k_thermal_unregister param type. These are warnings, no? "build error" and "compiler warning" are different things, the former breaks the whole build which is super critical, but I'll queue this to v5.7 nevertheless. And I'll change the title to: ath11k: fix compiler warning without CONFIG_THERMAL --=20 https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc= hes