mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Maarten ter Huurne <maarten@treewalker.org>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	od@zcrc.me, linux-kernel@vger.kernel.org,
	Mathieu Malaterre <malat@debian.org>,
	Artur Rojek <contact@artur-rojek.eu>
Subject: Re: [PATCH v3] clocksource: Add driver for the Ingenic JZ47xx OST
Date: Wed, 15 Jan 2020 22:50:19 +0100	[thread overview]
Message-ID: <87muaoxuck.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <1579121936.3.1@crapouillou.net>

Paul Cercueil <paul@crapouillou.net> writes:
> Le mer., janv. 15, 2020 at 20:54, Thomas Gleixner <tglx@linutronix.de> 
>> That lock still a massive contention point as clock readouts can be 
>> pretty
>> frequent depending on workloads. Just think about tracing ...
>> 
>> So I really would avoid both the lock and that ugly 64bit readout 
>> thing.
>
> The 64bit readout thing is gone in V3.
>
> The lock cannot go away unless we have a way to retrieve the underlying 
> mmio pointer from the regmap, which the regmap maintainers will never 
> accept. So I can't really change that now. Besides, 
> drivers/clocksource/ingenic-timer.c also registers a clocksource that's 
> read with the regmap, and nobody complained.

I don't complain. I just told you that a spinlock in that code path is
really suboptimal.

I missed the one in the other driver, but the same problem exists there.

Thanks,

        tglx

  reply	other threads:[~2020-01-15 21:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-14 15:06 Paul Cercueil
2020-01-15 13:44 ` Daniel Lezcano
2020-01-15 13:57   ` Paul Cercueil
2020-01-15 17:48     ` Maarten ter Huurne
2020-01-15 17:54       ` Paul Cercueil
2020-01-15 19:54         ` Thomas Gleixner
2020-01-15 20:58           ` Paul Cercueil
2020-01-15 21:50             ` Thomas Gleixner [this message]
2020-02-08  7:09             ` Daniel Lezcano
2020-02-08 13:23               ` Paul Cercueil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87muaoxuck.fsf@nanos.tec.linutronix.de \
    --to=tglx@linutronix.de \
    --cc=contact@artur-rojek.eu \
    --cc=daniel.lezcano@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten@treewalker.org \
    --cc=malat@debian.org \
    --cc=od@zcrc.me \
    --cc=paul@crapouillou.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome