From: Peter Korsgaard <peter@korsgaard.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-i2c@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 04/12] i2c: ocores: convert to use i2c_new_client_device()
Date: Tue, 07 Jan 2020 19:32:50 +0100 [thread overview]
Message-ID: <87muazjewd.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20200107174748.9616-5-wsa+renesas@sang-engineering.com> (Wolfram Sang's message of "Tue, 7 Jan 2020 18:47:38 +0100")
>>>>> "Wolfram" == Wolfram Sang <wsa+renesas@sang-engineering.com> writes:
> Move away from the deprecated API and return the shiny new ERRPTR where
> useful.
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
I didn't follow the discussion, but I don't see any returns anywhere?
> ---
> Build tested only.
> drivers/i2c/busses/i2c-ocores.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/drivers/i2c/busses/i2c-ocores.c b/drivers/i2c/busses/i2c-ocores.c
> index ca8b3ecfa93d..f5fc75b65a19 100644
> --- a/drivers/i2c/busses/i2c-ocores.c
> +++ b/drivers/i2c/busses/i2c-ocores.c
> @@ -731,7 +731,7 @@ static int ocores_i2c_probe(struct platform_device *pdev)
> /* add in known devices to the bus */
> if (pdata) {
> for (i = 0; i < pdata->num_devices; i++)
> - i2c_new_device(&i2c->adap, pdata->devices + i);
> + i2c_new_client_device(&i2c->adap, pdata->devices + i);
> }
> return 0;
> --
> 2.20.1
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2020-01-07 18:32 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 17:47 [PATCH 00/12] i2c: convert subsystem " Wolfram Sang
2020-01-07 17:47 ` [PATCH 01/12] i2c: cht-wc: convert " Wolfram Sang
2020-01-09 23:05 ` Hans de Goede
2020-01-07 17:47 ` [PATCH 02/12] i2c: i801: " Wolfram Sang
2020-01-09 8:54 ` Jean Delvare
2020-01-07 17:47 ` [PATCH 03/12] i2c: nvidia-gpu: " Wolfram Sang
2020-01-07 17:47 ` [PATCH 04/12] i2c: ocores: " Wolfram Sang
2020-01-07 18:32 ` Peter Korsgaard [this message]
2020-01-07 19:31 ` Wolfram Sang
2020-01-07 19:58 ` Peter Korsgaard
2020-01-07 19:36 ` Andrew Lunn
2020-01-07 17:47 ` [PATCH 05/12] i2c: powermac: " Wolfram Sang
2020-01-07 17:47 ` [PATCH 06/12] i2c: taos-evm: " Wolfram Sang
2020-01-08 10:58 ` Jean Delvare
2020-01-09 8:42 ` Jean Delvare
2020-01-15 19:56 ` Wolfram Sang
2020-01-07 17:47 ` [PATCH 07/12] i2c: xiic: " Wolfram Sang
2020-01-08 11:39 ` Michal Simek
2020-01-07 17:47 ` [PATCH 08/12] i2c: i2c-core-acpi: " Wolfram Sang
2020-01-08 10:04 ` Mika Westerberg
2020-01-07 17:47 ` [PATCH 09/12] i2c: i2c-core-base: " Wolfram Sang
2020-01-07 17:47 ` [PATCH 10/12] i2c: i2c-core-of: " Wolfram Sang
2020-01-07 17:47 ` [PATCH 11/12] docs: i2c: use the new API in 'instantiating-devices.rst' Wolfram Sang
2020-01-07 17:47 ` [PATCH 12/12] docs: i2c: use the new API in 'writing-clients' Wolfram Sang
2020-01-15 19:57 ` [PATCH 00/12] i2c: convert subsystem to use i2c_new_client_device() Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87muazjewd.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=andrew@lunn.ch \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®